? PHP 8.x ? Pending

User tests: Successful: Unsuccessful:

avatar svenbluege
svenbluege
15 Jan 2023

Deprecation messages are shown for some tagged elements:
image

Pull Request for Issue # .

Summary of Changes

In com_tags, a tagged element's text-variable is transformed into null if the value is empty.
That causes deprecation messages in plugins like loadmodules and emailcloak. They usually don't need to check for null values in $article->text.

Testing Instructions

  1. configure PHP to show deprecation messages
  2. create a new contact using com_contact: just enter a name and tag it with "testtag"
  3. open the frontend /index.php?option=com_tags&view=tags
  4. click on the new tag 'testtag'.
  5. see the deprecation messages.

Actual result BEFORE applying this Pull Request

Following the test instructions, deprecation messages are shown

Expected result AFTER applying this Pull Request

Following the test instructions, deprecation messages are now shown

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 15 Jan 2023
Category com_tags Front End
avatar svenbluege svenbluege - open - 15 Jan 2023
avatar svenbluege svenbluege - change - 15 Jan 2023
Status New Pending
avatar svenbluege svenbluege - change - 20 Jan 2023
Labels Added: ?
avatar Quy Quy - test_item - 20 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 20 Jan 2023

I have tested this item successfully on 803c9b7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39640.

avatar viocassel viocassel - test_item - 20 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 20 Jan 2023

I have tested this item successfully on 803c9b7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39640.

avatar Quy Quy - change - 20 Jan 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 20 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39640.

avatar svenbluege svenbluege - change - 21 Jan 2023
Labels Added: ?
avatar fancyFranci fancyFranci - change - 22 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-22 11:32:46
Closed_By fancyFranci
Labels Added: PHP 8.x
avatar fancyFranci fancyFranci - close - 22 Jan 2023
avatar fancyFranci fancyFranci - merge - 22 Jan 2023
avatar fancyFranci
fancyFranci - comment - 22 Jan 2023

Nice! Thank you!

avatar svenbluege
svenbluege - comment - 8 Mar 2023

@fancyFranci That issue reappeared in 4.3-dev. It looks like that change did not make it through in the merge. I added a PR for 4.3 here: #40048

Add a Comment

Login with GitHub to post a comment