Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39631] - [4.3] Remove unused install data and custom admin menus

Language Change bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
15 Jan 2023

Part 1
Banners, contact, finder and newsfeeds are all protected components that can not be uninstalled.
This PR removes the references to install and uninstall sql for these components and the referenced sql files
No point in maintaining files/code that can never be used.

Part 2
remove unused menu links in the component xml. They were used previously for the admin menu but were replaced by the xml for each view some time ago

Part 3
add missing menu link xml files for Banners, contacts, and newsfeeds and remove resultant references in the main component xml that are no longer used

Testing Instructions

Code review and
Create custom admin menu items for com_contacts, newsfeeds and banners

Before

image

After

image

@richard67 shall I add the files to the uninstall list or are you still doing that?

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 15 Jan 2023
Category ⇒ Administration com_banners com_contact com_finder com_newsfeeds
avatar brianteeman brianteeman - open - 15 Jan 2023
avatar brianteeman brianteeman - change - 15 Jan 2023
Status New ⇒ Pending
avatar brianteeman brianteeman - change - 15 Jan 2023
Labels Added: PR-4.3-dev
avatar brianteeman brianteeman - change - 15 Jan 2023
The description was changed
avatar brianteeman brianteeman - edited - 15 Jan 2023
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jan 2023
Category Administration com_banners com_contact com_finder com_newsfeeds ⇒ Administration com_associations com_banners com_contact com_finder com_newsfeeds com_redirect com_tags com_workflow
avatar brianteeman brianteeman - change - 15 Jan 2023
The description was changed
avatar brianteeman brianteeman - edited - 15 Jan 2023
avatar richard67
richard67 - comment - 15 Jan 2023

@richard67 shall I add the files to the uninstall list or are you still doing that?

@brianteeman I will do that.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Jan 2023
Category Administration com_banners com_contact com_finder com_newsfeeds com_associations com_redirect com_tags com_workflow ⇒ Administration com_associations com_banners com_contact com_finder com_newsfeeds com_redirect com_tags com_workflow Language & Strings
avatar brianteeman brianteeman - change - 15 Jan 2023
Title
…
[4.3] Remove unused install data
[4.3] Remove unused install data and custom admin menus
avatar brianteeman brianteeman - edited - 15 Jan 2023
avatar brianteeman brianteeman - change - 15 Jan 2023
The description was changed
avatar brianteeman brianteeman - edited - 15 Jan 2023
avatar brianteeman
brianteeman - comment - 15 Jan 2023

PS - if accepted I will update the component menu items to add the filters currently only in com_content AND add menu links to the edit form

avatar brianteeman brianteeman - change - 8 Sep 2023
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-08 11:52:21
Closed_By ⇒ brianteeman
Labels Added: Language Change bug
avatar brianteeman brianteeman - close - 8 Sep 2023

Add a Comment

Login with GitHub to post a comment