? PHP 8.x ? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
15 Jan 2023

Pull Request for Issue php 8.2 - dynamic property Deprecated

.### Summary of Changes
removed Creation of dynamic property item_associations

Testing Instructions

open frontend with php 8.2 with Error Reporting = maximum and multilaguage enabled

Actual result BEFORE applying this Pull Request

Deprecated: Creation of dynamic property Joomla\CMS\Application\SiteApplication::$item_associations is deprecated

Expected result AFTER applying this Pull Request

no more

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 15 Jan 2023
Category Front End Plugins
avatar alikon alikon - open - 15 Jan 2023
avatar alikon alikon - change - 15 Jan 2023
Status New Pending
avatar alikon alikon - change - 20 Jan 2023
Labels Added: PHP 8.x ?
avatar laoneo laoneo - test_item - 20 Jan 2023 - Tested successfully
avatar laoneo
laoneo - comment - 20 Jan 2023

I have tested this item successfully on 93d7c00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39630.

avatar HLeithner
HLeithner - comment - 20 Jan 2023

It's a b/c break isn't it?

avatar alikon
alikon - comment - 20 Jan 2023

are the plugin covered by b/c policies ?

avatar HLeithner
HLeithner - comment - 20 Jan 2023

It's similar to #39592 no idea if it has the same impact but we don't need to do breaks if it can be avoided and cleaned up in 5.0

avatar laoneo
laoneo - comment - 20 Jan 2023

It's similar to #39592 no idea if it has the same impact but we don't need to do breaks if it can be avoided and cleaned up in 5.0

Not really as in #39592 is the property added by a libraries class and actually used in a module. This here is just a leftover with no reference.

avatar HLeithner
HLeithner - comment - 20 Jan 2023

That's the reason I said similar and not the same.
Anyway any research don if a extension is using it?

avatar viocassel viocassel - test_item - 26 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 26 Jan 2023

I have tested this item successfully on 93d7c00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39630.

avatar Quy Quy - change - 26 Jan 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39630.

avatar laoneo
laoneo - comment - 27 Jan 2023

@alikon can you add the variable to the Application class so we can add a deprecation message in 4.3? Added a new label "Needs deprecation" so we will not forget.

avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2023
Category Front End Plugins Libraries Front End Plugins
avatar alikon alikon - change - 28 Jan 2023
Labels Added: ? ?
avatar alikon
alikon - comment - 28 Jan 2023

done

avatar laoneo
laoneo - comment - 30 Jan 2023

You need to remove the deprecation as we are not allowed to deprecate stuff in a patch release. But I gave it a proper label, so we can deprecate in 4.3 then.

avatar alikon
alikon - comment - 30 Jan 2023

ok done

avatar fancyFranci fancyFranci - change - 11 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-11 12:40:07
Closed_By fancyFranci
avatar fancyFranci fancyFranci - close - 11 Feb 2023
avatar fancyFranci fancyFranci - merge - 11 Feb 2023
avatar fancyFranci
fancyFranci - comment - 11 Feb 2023

Thank you!

Add a Comment

Login with GitHub to post a comment