? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
13 Jan 2023

Summary of Changes

Converts the tinymce editor to service providers.

Testing Instructions

  • Make sure TinyMCE is the default editor
  • Edit an article

Also test if the other editors do still work

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 13 Jan 2023
Category Libraries Front End Plugins
avatar laoneo laoneo - open - 13 Jan 2023
avatar laoneo laoneo - change - 13 Jan 2023
Status New Pending
53b65ed 13 Jan 2023 avatar laoneo cs
avatar laoneo laoneo - change - 13 Jan 2023
Labels Added: PR-4.3-dev
avatar dgrammatiko
dgrammatiko - comment - 13 Jan 2023

@laoneo thank you for the one! I'll test it in a bit

avatar dgrammatiko dgrammatiko - test_item - 13 Jan 2023 - Tested successfully
avatar dgrammatiko dgrammatiko - test_item - 13 Jan 2023 - Tested unsuccessfully
avatar laoneo
laoneo - comment - 13 Jan 2023

I'v uploaded a fix, it should work now. Strange thing was that it loaded without that change for me

avatar laoneo laoneo - change - 13 Jan 2023
The description was changed
avatar laoneo laoneo - edited - 13 Jan 2023
avatar dgrammatiko dgrammatiko - test_item - 13 Jan 2023 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 13 Jan 2023

I have tested this item successfully on 53b65ed

Tip for the next tester: delete the file administrator/cache/autoload_psr4.php prior testing


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625.

avatar brianteeman brianteeman - test_item - 15 Jan 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 15 Jan 2023

I have tested this item successfully on 15e3454

Based on the test instructions I am marking this as a successful test. Can't really comment on the code changes themselves


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625.

avatar viocassel viocassel - test_item - 15 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 15 Jan 2023

I have tested this item successfully on 15e3454


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625.

avatar laoneo laoneo - change - 15 Jan 2023
Status Pending Ready to Commit
avatar laoneo
laoneo - comment - 15 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625.

avatar laoneo laoneo - change - 15 Jan 2023
Labels Added: ?
avatar obuisard obuisard - change - 15 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-15 16:56:19
Closed_By obuisard
avatar obuisard obuisard - close - 15 Jan 2023
avatar obuisard obuisard - merge - 15 Jan 2023
avatar obuisard
obuisard - comment - 15 Jan 2023

Thank you Allon @laoneo!

Add a Comment

Login with GitHub to post a comment