Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39624] - Converts the authentication plugins to service providers

? ? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
13 Jan 2023

Summary of Changes

Converts the authentication plugins to service providers.

Testing Instructions

Log in on the back and front end. If possible also with Ldap.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 13 Jan 2023
Category ⇒ Front End Plugins
avatar laoneo laoneo - open - 13 Jan 2023
avatar laoneo laoneo - change - 13 Jan 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jan 2023
Category Front End Plugins ⇒ Front End Plugins Unit Tests
avatar laoneo laoneo - change - 13 Jan 2023
Labels Added: PR-4.3-dev
avatar carlitorweb
carlitorweb - comment - 13 Jan 2023

@laoneo set session time in global configuration to 1min, and login after in the front using the "Remember me" button, close the page. Wait that minute and back again to the page

Notice
: Only variables should be passed by reference in
/var/www/192.168.1.103/bugtesting/plugins/authentication/cookie/services/provider.php
on line
39
avatar carlitorweb
carlitorweb - comment - 13 Jan 2023

Except ldap I could not test, the rest work okay. Let me know if the notice message is important enough...if not I can mark the test successfully

avatar laoneo laoneo - change - 13 Jan 2023
Labels Added: ?
avatar laoneo
laoneo - comment - 13 Jan 2023

The notice should be fixed with the last commit. Thanks for reporting.

avatar carlitorweb carlitorweb - test_item - 13 Jan 2023 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 13 Jan 2023

I have tested this item ✅ successfully on 558f6dd

Remember clean autoload_psr4.php cached after apply the patch

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39624.

avatar laoneo
laoneo - comment - 15 Jan 2023

@tatankat can you test this one here as well as it converts the ldap auth plugin to service provider?

c6c61b4 18 Jan 2023 avatar laoneo cs
avatar dgrammatiko dgrammatiko - test_item - 19 Jan 2023 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 19 Jan 2023

I have tested this item ✅ successfully on c6c61b4

* the LDAP was not tested for actually authenticating (I don't have LDAP locally)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39624.

avatar laoneo laoneo - change - 19 Jan 2023
Status Pending ⇒ Ready to Commit
avatar laoneo
laoneo - comment - 19 Jan 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39624.

avatar obuisard obuisard - change - 19 Jan 2023
Labels Added: ?
avatar obuisard obuisard - change - 19 Jan 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-01-19 23:50:38
Closed_By ⇒ obuisard
avatar obuisard obuisard - close - 19 Jan 2023
avatar obuisard obuisard - merge - 19 Jan 2023
avatar obuisard
obuisard - comment - 19 Jan 2023

Thank you Allon @laoneo for the PR!

avatar tatankat
tatankat - comment - 21 Jan 2023

A bit too late for the party, but I can confirm ldap works as it should. Thanks for also updating the ldap plugin.

Add a Comment

Login with GitHub to post a comment