[#3961] - Address issues with current PHP 5.6 RC
- Closed
- 4 Aug 2014
- Medium
- Build: staging
- # 3961
- Diff
- mbabker:php56Testing
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This pull addresses issues found running PHPUnit on the PHP 5.6 RC 2 release.
1) JFormTest calling non-static methods of the test inspector class it uses statically (no production code/changes involved)
2) JFormTest has an inherent dependency on a database connection because of a chain of method calls within it causing the test class to fail when run in isolation (no production changes involved)
3) In PHP 5.6, the iconv_set_encoding() function and the settings it controls are deprecated in favor of a default_charset setting, see https://wiki.php.net/rfc/default_encoding for more info. The deprecation notices caused test errors on PHP 5.6.
Unit testing against PHP 5.4 and 5.6 are still good for me on my local system with these changes. The change in JString probably just needs someone to plug it into a site to make sure the settings still set correctly.
After it goes stable, sure. I was just being proactive while testing up my
new system setup.
On Friday, July 25, 2014, George Wilson > wrote:
Do you wanna turn on travis for 5.6 with this as well then?
—
Reply to this email directly or view it on GitHub
#3961 (comment).
Added 5.6 to Travis and had to skip the same tests we previously did due to a change in behavior in unserialize() (weirdly it works fine on my local install, same RC2 release as what Travis is running).
Looks good to me :)
phproberto
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-04 20:29:46 |
Sophist-UK
-
Do you wanna turn on travis for 5.6 with this as well then?