Feeling Lucky
?
NPM Resource Changed
?
[#39609] - [RFC] Fix subform multiple tinymce elements alternative
- Closed
- 15 Jan 2023
- Medium
- Build: 4.2-dev
- # 39609
- Diff
- dgrammatiko:4.2-dev-tinyButtons
User tests: Successful: Unsuccessful:
Pull Request is an alternative to #39449 which is for Issue #39416 .
Summary of Changes
- The buttons PHP code has been reworked to pass data to JS
- There is no server side rendering of the modals, it would happen on the fly, when a user requests a modal
- There is some code that tries to replace the
editorid both for click action and for the modals callback, etc - due to CSR all the ids should be always correct for any subform combination
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Screen.Recording.2023-01-11.at.22.25.17.mov
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Layout Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
NPM Resource Changed
?
|
||
dgrammatiko
- comment
- 15 Jan 2023
I mean I can add some events to let devs fill the dialog and remove the eval parts (I didn't introduce them now, they existed).
Anyways I though I will give it a try
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-15 15:34:36 |
| Closed_By | ⇒ | dgrammatiko |
hou hou hou? ?
no, sorry, that to much hacky, better keep that bug alive for some time