Feeling Lucky
?
PR-4.3-dev
[#39597] - [4.3] Fix build tools Media Manager up merge
- Fixed in Code Base
- 12 Jan 2023
- Medium
- Build: 4.3-dev
- # 39597
- Diff
- dgrammatiko:4.3-dev-build-tools-mm
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- when up merged from 4.2 one line was wrongly left there (my bad)
- Couple of changes, inline the source map (dev) + watch defaults to dev mode
Testing Instructions
Run npm ci, build:com_media:dev build:com_media and watch:com_media and confirm that the media manager is working
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
@obuisard please consider merging this one before the next alpha, thanks
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
obuisard
- comment
- 11 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39597.
viocassel
- comment
- 12 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39597.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 12 Jan 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39597.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-12 16:04:34 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
HLeithner
- comment
- 12 Jan 2023
thanks
Thanks Dimitris @dgrammatiko. I will test it later today. It will definitely be included in upcoming alpha 3.