? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar JackKellyUK
JackKellyUK
7 Jan 2023

Pull Request for Issue #34682.

Summary of Changes

Adjusted select background size to prevent bleeding.

Testing Instructions

  1. Login to the Joomla 4 backend
  2. Go to Components -> Banners
  3. Create a new banner
  4. Click on the banner details tab
  5. Increase screen dimensions to atleast 2400px

Actual result BEFORE applying this Pull Request

Background on selects begin to bleed at ~ 2400px
image

Expected result AFTER applying this Pull Request

Backgrounds no longer bleed on selects at ~ 2400px+
image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 7 Jan 2023
Category Repository NPM Change
avatar JackKellyUK JackKellyUK - open - 7 Jan 2023
avatar JackKellyUK JackKellyUK - change - 7 Jan 2023
Status New Pending
avatar JackKellyUK JackKellyUK - change - 7 Jan 2023
The description was changed
avatar JackKellyUK JackKellyUK - edited - 7 Jan 2023
avatar JackKellyUK
JackKellyUK - comment - 8 Jan 2023

Dont have UWS, but setting max to 100% seems reasonable :)

I don't think you need an ultrawide to test, you should be able to set screen dimensions in your browsers dev tools.

avatar wojtekxtx
wojtekxtx - comment - 8 Jan 2023

you should be able to set screen dimensions in your browsers dev tools.

@JackKellyUK thats correct ? I was able to do this and can confirm your issue.

avatar brianteeman brianteeman - test_item - 9 Jan 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 9 Jan 2023

I have tested this item successfully on 8e17ce4

tested successfully in both LTR and RTL


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39569.

avatar viocassel viocassel - test_item - 9 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 9 Jan 2023

I have tested this item successfully on 8e17ce4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39569.

avatar Quy Quy - change - 9 Jan 2023
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 9 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39569.

avatar roland-d roland-d - change - 9 Jan 2023
Labels Added: ?
avatar roland-d roland-d - change - 9 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-09 17:23:59
Closed_By roland-d
Labels Added: NPM Resource Changed
avatar roland-d roland-d - close - 9 Jan 2023
avatar roland-d roland-d - merge - 9 Jan 2023
avatar roland-d
roland-d - comment - 9 Jan 2023

Thank you

Add a Comment

Login with GitHub to post a comment