[#39568] - [4.x] Change the button class in the pagebreak plugin
- Closed
- 12 Jan 2023
- Medium
- Build: 4.2-dev
- # 39568
- Diff
- sandewt:patch-7
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The button class corresponds to that of the page navigation, so that the same style here is used.
The dimensions of the button are slightly larger than those of the page navigation.
Testing Instructions
- Make a page break and check out the new buttons
- Code review
Actual result BEFORE applying this Pull Request
The button class corresponds NOT to that of the page navigation.
Expected result AFTER applying this Pull Request
The button class corresponds to that of the page navigation.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
And can’t it be achieved with a user.css file?
yes its a b/c break which even if not guranteed by the policy is still a disruptive change for little benefit.
it also relies exclusively on bootstrap classes which may not be present.
my 2c This should be closed as it can be achieved if you desire either with user.css or with an override
I agree with Brian on this.
yes its a b/c break which even if not guranteed by the policy is still a disruptive change for little benefit.
It looks messy if the styling is different within joomla.
it also relies exclusively on bootstrap classes which may not be present.
The classes used in this pr are just standard in bootstrap.
Thanks all for the info. I'm trying to understand your comments. In what case(s) is b/c mentioned here exactly?
So, I seem to remember that such a PR has already been carried out in the past. So I went looking and found this...
#38236 and see line 23 and 34 https://github.com/joomla/joomla-cms/pull/38236/files
Conclusion: such a change has already been made before, or I really miss seeing it completely wrong :-)
The classes used in this pr are just standard in bootstrap.
So all sites that are not using bootstrap will have their layout disturbed
That PR should not have been merged either for the same reasons (yes - I know who wrote it)
So all sites that are not using bootstrap will have their layout disturbed
If I close this PR, this information may be lost.
When is the time to implement such a change? Already in Joomla 5? What is wisdom?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39568.
b/ c break
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-12 12:04:10 |
| Closed_By | ⇒ | sandewt | |
| Labels |
Added:
?
|
||
Isn’t this a b/c break?