@richard67 I guess I could additionally check to see if DEV_STATUS = Development and then either remove the link or link to the nightly page https://developer.joomla.org/nightly-builds.html

@richard67 I guess I could additionally check to see if DEV_STATUS = Development and then either remove the link or link to the nightly page https://developer.joomla.org/nightly-builds.html

@brianteeman That could be a way. Not sure yet which of the 2 is better. Let's see if we get more opinions.

PR updated and original description updated

I will check and test tomorrow.

@brianteeman When testing on a development environment with the current branch of this PR (or with a 4.2-dev branch and this PR's changes applied), it needs to patch also the following in the Version.php file, in addition to what you have mentioned already in the testing instructions:
public const DEV_STATUS = 'Stable';

In addition, it needs to go to the database checker after having modified Version.php. It will report a CMS version mismatch with the database. Using the fix button will then update it in the database to what is in Version.php. This was necessary for me to get an update found.

Maybe the testing instructions should be updated by the above findings.

For testing development status, I have done tests with several patches of Version.php, e.g. not only development but also alpha, beta and rc packages. Everything which is not stable, i.e. also alpha, beta and rc, are considered as development status and so the link goes to the nightly builds for these. I am ok with that, just wanted to mention.

In general I am not sure if it is a good thing that when an update is found, the link points to the zip package directly, and in other cases to different download sites depending on stable or development, all with the same link text "the official Joomla download page". Maybe this can confuse the user? I'd like to have more opinions from others on this.

In general I am not sure if it is a good thing that when an update is found, the link points to the zip package directly,

That is the behaviour before this PR

In general I am not sure if it is a good thing that when an update is found, the link points to the zip package directly,

That is the behaviour before this PR

@brianteeman Not 100%. Without this PR, the download link is in an additional message, and the link in the regular message still allows to go to the downloads page and then using the diverse buttons to come to the upgrade package. In past (3.10), people could use this link to download one of the smaller patch packages. With your PR that would not be possible anymore. Ok, currently we don't build the patch packages so your PR is ok. But as soon as we make that work again and build the patch packages, people would not be able to find a suitable link.

So maybe it would be good to have 2 messages like before, the first one with your change for either pointing to the download page of the nightlies if on a development version or the download page of the current version when on a stable version, so people could still find patch packages there when we build them again in future, and optionally the 2nd message with the download link of the update when an update has been found.

P.S.: I do not request any changes. Am only making suggestions for further discussion.

This pull request has been automatically rebased to 4.3-dev.