Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39552] - Convert mod_articles_categories to new structure

? ? ? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar carlitorweb
carlitorweb
3 Jan 2023

Summary of Changes

This PR converts mod_articles_categories to the new structure

Testing Instructions

  • Use Joomla 4.3
  • Create an instance of the module Articles - Categories. Note how it works.
  • Apply patch
  • Delete administrator/cache/autoload_psr4.php
  • Refresh the page, make sure the module still displays the same as before.

Additional comments

I not sure of the best approach to use cache here, if is needed.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2023
Category ⇒ Modules Front End
avatar carlitorweb carlitorweb - open - 3 Jan 2023
avatar carlitorweb carlitorweb - change - 3 Jan 2023
Status New ⇒ Pending
avatar carlitorweb carlitorweb - change - 5 Jan 2023
Labels Added: PR-4.3-dev
avatar chmst chmst - change - 6 Jan 2023
Easy No ⇒ Yes
avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2023
Category Modules Front End ⇒ Administration Modules Front End
avatar carlitorweb carlitorweb - change - 13 Mar 2023
Labels Added: PR-4.4-dev
Removed: PR-4.3-dev
avatar carlitorweb
carlitorweb - comment - 13 Mar 2023

@Quy any hint why is failing here the drone?

avatar Quy
Quy - comment - 13 Mar 2023

Click on Details.
Click on phpcs to see the console logs.

avatar carlitorweb
carlitorweb - comment - 13 Mar 2023

Yes I did that....

avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2023
Category Modules Front End Administration ⇒ Modules Front End
avatar laoneo laoneo - change - 29 Mar 2023
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2023
Category Modules Front End ⇒ Modules Front End JavaScript Unit Tests
avatar carlitorweb
carlitorweb - comment - 30 Mar 2023

@laoneo cy test added

avatar carlitorweb carlitorweb - change - 30 Mar 2023
Labels Added: ?
avatar carlitorweb
carlitorweb - comment - 31 Mar 2023

@laoneo I think in this module is not needed revert the Helper class, mainly here what is done is removing the Categories::getInstance deprecated function, and changed some variables name.

But please, let me kown if you need I revert the whole Helper class.

avatar laoneo laoneo - change - 3 Apr 2023
Labels Removed: ?
avatar carlitorweb
carlitorweb - comment - 3 Apr 2023

I will include the cache

avatar laoneo laoneo - change - 11 Apr 2023
Labels Added: ? ?
avatar laoneo
laoneo - comment - 11 Apr 2023

Can you include the cache the same way as in #40316?

avatar laoneo laoneo - change - 13 Apr 2023
Labels Removed: ?
avatar laoneo laoneo - test_item - 13 Apr 2023 - Tested successfully
avatar laoneo
laoneo - comment - 13 Apr 2023

I have tested this item ✅ successfully on 964bb0b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39552.

avatar drmenzelit drmenzelit - test_item - 13 Apr 2023 - Tested successfully
avatar drmenzelit
drmenzelit - comment - 13 Apr 2023

I have tested this item ✅ successfully on 964bb0b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39552.

avatar laoneo laoneo - change - 13 Apr 2023
Status Pending ⇒ Ready to Commit
avatar laoneo
laoneo - comment - 13 Apr 2023

rtc

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39552.

avatar MacJoom MacJoom - change - 14 Apr 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-04-14 09:10:42
Closed_By ⇒ MacJoom
Labels Added: ?
avatar MacJoom MacJoom - close - 14 Apr 2023
avatar MacJoom MacJoom - merge - 14 Apr 2023

Add a Comment

Login with GitHub to post a comment