[#39535] - Convert mod_articles_archive to new structure
- Fixed in Code Base
- 3 Apr 2023
- Medium
- Build: 4.3-dev
- # 39535
- Diff
- carlitorweb:convert_mod_articles_archive
User tests: Successful: Unsuccessful:
Summary of Changes
This PR converts mod_articles_archive to the new structure
Testing Instructions
- Use Joomla 4.3
- Create an instance of the module Articles - Archived. Note how it works.
- Apply patch
- Delete administrator/cache/autoload_psr4.php
- Refresh the page, make sure the module still displays the same as before.
Additional comments
A small change to the layout was made. Now will show the amount of articles the month have archived, for example:
Before patch:
December, 2022
After patch:
December, 2022 (1)
If is not allowed, let me kown and I revert the change
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
Sure, change it. More accurate names are always better...
| Category | Modules Front End | ⇒ | Administration Modules Front End |
| Category | Modules Front End Administration | ⇒ | Modules Front End |
| Labels |
Added:
PR-4.4-dev
Removed: PR-4.3-dev |
||
| Labels |
Added:
?
|
||
| Category | Modules Front End | ⇒ | Modules Front End JavaScript Unit Tests |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-03 13:03:49 |
| Closed_By | ⇒ | laoneo |
Thank you very much, the end result is really nice!
No problem, next time will be much easier. I'm glad that people do step up and help me converting core extensions.
Thanks for the hint, can you make a new pr for this?
I noticed even more details in the already modified modules. I think it would be useful to change those as well, so that they become more consistent. But first gain some more experience with the modules.
@laoneo the name of the method
getArticles()do not describe really the purpose of the method. Can be changed for this module to something likegetMonths()for example?