[#39518] - [4.3] Show message "No Media Found" for empty folder in Media Manager
- Closed
- 27 Jan 2023
- Medium
- Build: 4.2-dev
- # 39518
- Diff
- rajputanuj31:4.2-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #31340
Added message for no media files-
If no media files in Media then message no media files will be displayed to user if user clicked on checkbox
Testing Instructions
Create a new folder in Media and open it (No files should be present)
Expected Result Before PR
No message
Expected Result After PR
A message "No Media Found" will be displayed
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-28 20:17:09 |
| Closed_By | ⇒ | rajputanuj31 |
| Status | Closed | ⇒ | New |
| Closed_Date | 2022-12-28 20:17:09 | ⇒ | |
| Closed_By | rajputanuj31 | ⇒ |
| Status | New | ⇒ | Pending |
@rajputanuj31 Joomla has to work with other languages than English, too, so we can't use a hardcoded English text here.
@rajputanuj31 thanks for your contribution! Skills in vue.js are very appreciated.
Joomla is a huge system and of course you cannot know everything - but you can learn,
If you are interested in GSoC 2023, join us on mattermost https://joomlacommunity.cloud.mattermost.com/main/channels/gsoc2023
Please check how to use the if/else conditionals on the html part of the vue file. You don't have to create elements manually as vue has a simpler way for that...
| Labels |
Added:
?
|
||
Great to see that you worked on the issue and want to contribute your result!
Every pull request needs 2 successful user tests. To have a higher chance to get those tests: Please have a look on the descriptions of other pull requests here and how they are structured. "Summary of Changes", "Testing Instructions", before and after applying the patch etc. Add this structure to your PR description as well and you will make it easier for others to test your changes. Screenshots are very helpful too.
| Category | Administration com_media NPM Change | ⇒ | Administration com_media NPM Change Language & Strings |
| Labels |
Added:
Language Change
Removed: ? |
||
@rajputanuj31 please run npm run lint:js -- --fix to fix the codestyle, nice work!
@rajputanuj31 please run
npm run lint:js -- --fixto fix the codestyle, nice work!
Would be even better if @rajputanuj31 would follow @fancyFranci ' recommendation above and change the title to something meaningful, add some description and finally some testing instructions.
| Title |
|
||||||
@rajputanuj31 You have to add the new string also to the administrator language file below this line here:
. Otherwise you see "COM_MEDIA_NO_MEDIA_FOUND" instead of "No Media Found" when using the Media Manager in backend (administrator).| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39518.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39518.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39518.
| Category | Administration com_media NPM Change Language & Strings | ⇒ | Administration com_admin com_finder com_media NPM Change com_menus Language & Strings JavaScript Repository com_tags Front End Installation Libraries |
obuisard
- | Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39518.
@richard67 please remove the RTC flag here. This still needs:
- better css/presentaion (ie resemble the other empty state pages)
- be aware of the loading state (ie not display until fetching of the data is complete)
- tweaks on the list view
For the first 2 the code exists in #39709 the 3rd one needs some tweaks on the relative component
Quy
- | Status | Ready to Commit | ⇒ | Pending |
@dgrammatiko since the base branch has been changed and there are lot of conflicts. I am unable to understand what should I do. Please guide me a bit.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-27 19:13:30 |
| Closed_By | ⇒ | rajputanuj31 | |
| Labels |
Added:
?
PR-4.3-dev
Removed: ? |
||
this is only good for english