[#39503] - [4.2] PHP8.2 deprecated dynamic properties
- Fixed in Code Base
- 12 Jan 2023
- Medium
- Build: 4.2-dev
- # 39503
- Diff
- heelc29:4.2/php82/dynamic-properties/helperfactory
User tests: Successful: Unsuccessful:
Summary of Changes
The creation of dynamic properties is deprecated
Testing Instructions
Open frontend where mod_articles_latest and/or mod_articles_news are displayed
Actual result BEFORE applying this Pull Request
PHP Deprecated: Creation of dynamic property Joomla\Module\ArticlesLatest\Site\Dispatcher\Dispatcher::$helper is deprecated in libraries/src/Helper/HelperFactoryAwareTrait.php on line 61
PHP Deprecated: Creation of dynamic property Joomla\Module\ArticlesNews\Site\Dispatcher\Dispatcher::$helper is deprecated in libraries/src/Helper/HelperFactoryAwareTrait.php on line 61
Expected result AFTER applying this Pull Request
No deprecated message
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
ping @laoneo who introduced helper factory aware interface in #37445
I'm not sure if this the "right" fix for b/c, also the variable names of the interface and trait do not match:
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39503.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39503.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39503.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-12 15:22:27 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
PHP 8.x
Removed: ? |
||
thanks
Presumably this didn't get into 4.2.7? Still seems to be a problem on 4.3.1. I'm seeing
Deprecated: Creation of dynamic property JFormFieldMediaJce::$mediatype is deprecated in <mySite>/libraries/src/Form/FormField.php on line 591
This is ok like that. Was probably a copy paste error at that time.