? PHP 8.x ? Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
26 Dec 2022

Summary of Changes

The creation of dynamic properties is deprecated

https://www.php.net/manual/en/migration82.deprecated.php#migration82.deprecated.core.dynamic-properties

Add header property to magic __get and __set methods

Testing Instructions

Open category edit view with workflows enabled (com_categories/category/edit)

Actual result BEFORE applying this Pull Request

PHP Deprecated: Creation of dynamic property Joomla\CMS\Form\Field\SqlField::$header is deprecated in libraries/src/Form/FormField.php on line 591

Expected result AFTER applying this Pull Request

No deprecated message

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 26 Dec 2022
Category Libraries
avatar heelc29 heelc29 - open - 26 Dec 2022
avatar heelc29 heelc29 - change - 26 Dec 2022
Status New Pending
avatar laoneo laoneo - test_item - 11 Jan 2023 - Tested successfully
avatar laoneo
laoneo - comment - 11 Jan 2023

I have tested this item successfully on c7038ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39502.

avatar laoneo laoneo - change - 11 Jan 2023
Labels Added: PHP 8.x ?
avatar laoneo
laoneo - comment - 11 Jan 2023

The CalendarField has the same issue.

avatar carlitorweb carlitorweb - test_item - 12 Jan 2023 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 12 Jan 2023

I have tested this item successfully on 7975d0c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39502.

avatar joomdonation joomdonation - change - 12 Jan 2023
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 12 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39502.

avatar HLeithner HLeithner - change - 12 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-12 15:21:21
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 12 Jan 2023
avatar HLeithner HLeithner - merge - 12 Jan 2023
avatar HLeithner
HLeithner - comment - 12 Jan 2023

thanks

Add a Comment

Login with GitHub to post a comment