? bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar carlitorweb
carlitorweb
25 Dec 2022

Summary of Changes

If you login in the administration with a user who not have the Execute Transition permission and enter to the articles view, a warning error show up:

Warning: Undefined array key "value" in ..\joomla-cms\administrator\components\com_content\src\View\Articles\HtmlView.php on line 190

Warning: Undefined array key "value" in ..\joomla-cms\administrator\components\com_content\src\View\Articles\HtmlView.php on line 192

Testing Instructions

  • Go to the com_content options and Enable Workflow

  • Create a user with the follow permissions and login with him, in the administration area:
    Captura

  • Go back to the articles view

Actual result BEFORE applying this Pull Request

A list of errors show up (one for each transition button the view render)

Expected result AFTER applying this Pull Request

  • Not errors show up

Note: The change in the HtmlView.php file is for fix the previous explained error. But when that happen another related error show up:

Warning: Undefined array key "from_stage_id" in ..\joomla-cms\administrator\components\com_content\src\Helper\ContentHelper.php on line 73

This is expected to happen, because the tmpl/default.php file do not check also if the user can execute a transition. So a little adjust is made there too.

Note: Therefor, the Admin Featured Articles View have the same error. I will glad make the PR for that one after this one get reviewed.:

avatar joomla-cms-bot joomla-cms-bot - change - 25 Dec 2022
Category Administration com_content
avatar carlitorweb carlitorweb - open - 25 Dec 2022
avatar carlitorweb carlitorweb - change - 25 Dec 2022
Status New Pending
avatar carlitorweb carlitorweb - change - 25 Dec 2022
Labels Added: ?
avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 4.3-dev.

avatar heelc29 heelc29 - test_item - 26 Aug 2023 - Tested successfully
avatar heelc29
heelc29 - comment - 26 Aug 2023

I have tested this item ✅ successfully on c8f486f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39490.

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 4.4-dev.

avatar viocassel viocassel - test_item - 15 Nov 2023 - Tested successfully
avatar viocassel
viocassel - comment - 15 Nov 2023

I have tested this item ✅ successfully on c8f486f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39490.

avatar Quy Quy - change - 15 Nov 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 15 Nov 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39490.

avatar Quy Quy - change - 15 Nov 2023
Labels Added: ? bug PR-4.4-dev
Removed: ?
avatar MacJoom MacJoom - change - 15 Nov 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-11-15 17:42:15
Closed_By MacJoom
Labels Added: ?
Removed: ?
avatar MacJoom MacJoom - close - 15 Nov 2023
avatar MacJoom MacJoom - merge - 15 Nov 2023

Add a Comment

Login with GitHub to post a comment