[#39489] - Update Table.php
- Fixed in Code Base
- 29 Dec 2022
- Medium
- Build: 4.2-dev
- # 39489
- Diff
- Kurantje:patch-1
User tests: Successful: Unsuccessful:
Query requires back-quoted table name to acommodate for table names with special characters.
Pull Request for Issue #39487
Summary of Changes
On line 734 it states: ->from($this->_tbl);
This should be: ->from($this->_db->quoteName($this->_tbl));
Testing Instructions
Create a component using a table with a special character, e.g. da-events
Go to ...?option=&view=event&layout=edit&id=1 to get the first element from the table
Actual result BEFORE applying this Pull Request
Invalid mySQL query exception
Expected result AFTER applying this Pull Request
In edit.php get the data from the da-events table for id=1
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
There are some more code places that must be fixed via quoteName().
At least methods checkOut(), checkIn(). but I didn't test any further. Just opened and closed an item in my test component where I renamed the main table from ghsthing to ghsvs-thing and added protected $_tbl = '#__ghsvs-thing'; in my table class (extends Table). I got errors like example:
1064 You have an error in your SQL syntax;
check the manual that corresponds to your MariaDB server version
for the right syntax to use near '-thing SET `checked_out` = 340 ,
`checked_out_time` = '2022-12-24 19:22:39' ...' at line 1
I didn't save or update and so on then.
The first fix of this pr ( load() ) works, but ... see above.
@Kurantje
I have provided a pr in your branch that you can merge into your branch and into this pr at the same time if you like to.
See Kurantje#1
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-26 14:02:21 |
| Closed_By | ⇒ | Kurantje |
| Status | Closed | ⇒ | New |
| Closed_Date | 2022-12-26 14:02:21 | ⇒ | |
| Closed_By | Kurantje | ⇒ |
| Status | New | ⇒ | Pending |
Oops! Didn't mean to. Will reopen. Thanks!
I have tested this item
- PHP 8.1.13
- MySQLi 10.5.18-MariaDB-1:10.5.18+maria~ubu2004-log
- Joomla 4.3.0-alpha2-dev
- Joomla_4.2.7-dev
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39489.
I have tested this item
Code review + tried to view, delete, publish, unpublish.... records and all still works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39489.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks !
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39489.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-29 10:47:56 |
| Closed_By | ⇒ | roland-d |
Thank you
I have tested this item? unsuccessfully on 158adff
See my comment below
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39489.