? ? Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
23 Dec 2022

Summary of Changes

The feature to move an user to a group is broken after #38596.

Variable $users is not assigned in this if-case. Use the correct variable $userIds like it was before #38596

// Remove users from the group
$query->delete($db->quoteName('#__user_usergroup_map'))
->whereIn($db->quoteName('user_id'), $userIds);

Testing Instructions

Try moving a user to a group using the batch command.
image

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

The user is moved to the new group.
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar joomla-cms-bot joomla-cms-bot - change - 23 Dec 2022
Category Administration com_users
avatar heelc29 heelc29 - open - 23 Dec 2022
avatar heelc29 heelc29 - change - 23 Dec 2022
Status New Pending
avatar alikon alikon - test_item - 24 Dec 2022 - Tested successfully
avatar alikon
alikon - comment - 24 Dec 2022

I have tested this item successfully on e3326d8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39483.

avatar ceciogit ceciogit - test_item - 24 Dec 2022 - Tested successfully
avatar ceciogit
ceciogit - comment - 24 Dec 2022

I have tested this item successfully on e3326d8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39483.

avatar richard67 richard67 - change - 24 Dec 2022
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 24 Dec 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39483.

avatar wilsonge wilsonge - change - 28 Dec 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-12-28 12:16:32
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 28 Dec 2022
avatar wilsonge wilsonge - merge - 28 Dec 2022
avatar wilsonge
wilsonge - comment - 28 Dec 2022

Thanks!

Add a Comment

Login with GitHub to post a comment