Feeling Lucky
?
?
Maintainers Checked
[#39482] - [4.2] fix admin module popular
- Fixed in Code Base
- 28 Dec 2022
- Medium
- Build: 4.2-dev
- # 39482
- Diff
- heelc29:4.2/admin/modules/popular
User tests: Successful: Unsuccessful:
Summary of Changes
Add created_by to list select query to get article items.
The created_by property is required if the core.edit permission is not allowed. Function was added with #36559.
Testing Instructions
Check the admin dashboard with a user with these permissions on com_content:
Actual result BEFORE applying this Pull Request
PHP Warning: Undefined property: stdClass::$created_by in [ROOT]\administrator\modules\mod_popular\src\Helper\PopularHelper.php on line 90
Expected result AFTER applying this Pull Request
Link to edit own article is displayed (and no PHP warning)
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Status | New | ⇒ | Pending |
ReLater
- comment
- 25 Dec 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39482.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
richard67
- comment
- 25 Dec 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39482.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-28 12:21:11 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Maintainers Checked
|
||
wilsonge
- comment
- 28 Dec 2022
Thanks!
I have tested this item✅ successfully on 59956eb
Note: For get the right permission the test require, is enough with create a user under Author group and add the "Access Administration Access" from the global configuration permissions.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39482.