[#39466] - [5.2] Fix components rendering the document for no reason
- Pending
- Medium
- Build: 4.3-dev
- # 39466
- Diff
- wilsonge:fix/multiple-render
User tests: Successful: Unsuccessful:
Pull Request for Issue #39458 .
Summary of Changes
Fixes the fact we were returning a rendered html document to the controller which was then being totally ignored. Instead the view now returns void in a similar approach to how HTML documents are rendered. This is technically a b/c break as the return type has changed. However as the controller has never used this value and the document is re-rendered as part of the Application package for display on screen the chances of this impacting any extensions is exceptionally low. But I've put this against the 4.3 branch to be safe
Testing Instructions
Drone tests continue to pass showing there is no difference in the api behaviour before and after this PR. Users can choose any endpoint and behaviour should be unchanged whilst there should be a negligible performance increase as we don't double render the document.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
It's a shame we did not include this in 4.3, I apologize for the oversight. George @wilsonge then we would not have any issue including this in 5.0. What do you thing Harald @Hackwar?
@obuisard You wanted to ping Harald @HLeithner , but you've pinged Hannes ?
This pull request has been automatically rebased to 4.4-dev.
I would say 6.0 is the right target branch as George pointed out the bc break, even when it is minor.
I would also need to be documented in the migration developer docs and maybe also deprecation comments.
| Labels |
Added:
Documentation Required
PBF
bug
PR-4.4-dev
Removed: PR-4.3-dev |
||
| Title |
|
||||||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
It's a shame we did not include this in 4.3, I apologize for the oversight. George @wilsonge then we would not have any issue including this in 5.0. What do you thing Harald @Hackwar?