? Success

User tests: Successful: Unsuccessful:

avatar itbra
itbra
22 Jul 2014

The table key name has already been assigned to $key in line 1064 and is good to be used again. There's no need to introduce another variable for the sake of model state update.

Associated Bug tracker item

avatar itbra itbra - open - 22 Jul 2014
avatar Bakual
Bakual - comment - 22 Jul 2014

:+1:

avatar b2z
b2z - comment - 25 Jul 2014

:+1: good catch :)

avatar itbra itbra - change - 27 Jul 2014
Title
Remove re-definition of table key name
[#34000] Remove re-definition of table key name
avatar Kubik-Rubik
Kubik-Rubik - comment - 27 Jul 2014

@itbra Works!

3 testers -> can be merged. Thank you!

avatar brianteeman brianteeman - change - 8 Aug 2014
Labels Added: ?
avatar Bakual Bakual - change - 8 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-08 20:27:52
avatar Bakual Bakual - close - 8 Aug 2014
avatar Bakual Bakual - close - 8 Aug 2014
avatar Sophist-UK Sophist-UK - reference | 641592a - 7 Oct 14

Add a Comment

Login with GitHub to post a comment