[#3945] - Fixing $query->setLimit
- Closed
- 26 Jul 2014
- Medium
- Build: staging
- # 3945
- Diff
- Bakual:FixSetLimit
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This should fix the issue raised with #3940
Currently, $query->setLimit() is overriden by $db->query(). Making the method kind of useless.
This PR will make it so that setQuery checks if there is a limit or offset property set in the $query and uses that one if it's set and setQuery doesn't have an own value set already.
To test you can use the Ajax example plugin like described in the original Issue:
- Download https://github.com/Joomla-Ajax-Interface/Ajax-Latest-Articles/archive/875f1f4348b1e856539360dea4317097689db2c7.zip
- Install the plugin
- Use the URL
index.php?option=com_ajax&plugin=latestarticles&format=debug - Verify that the response from the plugin respects the parameter.
no need tests?
You mean unit tests or usage tests?
@malukenho You want to write some? I don't think there is currently one dealing with that. So it would be very welcome.
https://github.com/wilsonge/joomla-cms/compare/joomla:staging...patch-2?quick_pull=1 try adding the unit tests here
Nicely done.
Tracker item at http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33983
We need one more successful test
Yeah I can. Whatever works. I just added the fix to show that the bug is fixed after the patch is applied
I am sorry I am lost. What is now the patch to be tested? (me probably
missing out but sure just give me a hand ;-) ) Gimme the correct link
please?
On 7/25/2014 8:46 PM, George Wilson wrote:
Yeah I can. Whatever works. I just added the fix to show that the bug
is fixed after the patch is applied—
Reply to this email directly or view it on GitHub
#3945 (comment).
Leo Lammerink
MD GWS - Enterprise Ltd
Skype: gwsgroup
www.gws-desk.com http://www.gws-desk.com | www.gws-host.com
http://www.gws-host.com | www.gws-deals.today http://gws-deals.today
It's fine as is. I can merge this PR and take the unittest commit from Georges PR.
The patch is the same. One just comes with unit tests to prevent the bug reoccurring.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-26 14:57:29 |
Sophist-UK
-
Works like charm. Thanks @Bakual!