I have nothing against this change BUT don't we end up with an inconsistent ui with this only for site modules

I have nothing against this change BUT don't we end up with an inconsistent ui with this only for site modules

I agree it would be inconsitent, I'm happy to implement across other filters. My only concern is that when there are only 1 or 2 options it seems unnecessary?

You should not enable it for everything, only when it realy need

You should not enable it for everything, only when it realy need

Where do we draw the line? Only applying the layout to some of the filters will lead to inconsistency as @brianteeman mentioned.

Generally a fancy select type drop-down is appropriate when there are (expected to be) more than 4 options. Fewer than that it doesn't really make sense or provide any meaningful benefit.

Enable it for Menu select, that should be enough.
For fields like State, Language etc. it does not make sense to use it.

Only applying the layout to some of the filters will lead to inconsistency

It will be okay. Look for filters in Article, there Tags and Category are fancy-select, a rest is normal select.

Also a heads up that a new select element will be landing in 2023, named selectmenu and will probably deprecate the choices.js. So keep in mind that someone will soon have to revert all these changes and just use a native HTML element (yes, it has a polyfill, so once there's a consensus on the attr/props/methods Joomla can start shipping it, follow the openui project on discord for updates). BTW also dropdowns and other things from Bootstrap soon will need 0 JS and could be done with plain HTML/CSS...

It will be okay. Look for filters in Article, there Tags and Category are fancy-select, a rest is normal select.

These have multiple set to true, so they don't have the additional search appear, but appreciate your point.

Okay, the layout is now only applied to the Position, Type and Menu Item as these are the core issue.

I still think there is room for discussion around the consistancy of the filters UI in general.

Enable it for Menu select, that should be enough. For fields like State, Language etc. it does not make sense to use it.
Only applying the layout to some of the filters will lead to inconsistency
It will be okay. Look for filters in Article, there Tags and Category are fancy-select, a rest is normal select.

I would say more, in addition to the select menu also in the "Select Parent Menu Item". I have a site where the main menu is extensive and has several menu items with submenus.
When I need to edit a submenu, being able to fetch it for filtering helps a lot.
By the way, in general, for those who use a computer/keyboard it is more practical to type than to search on the scroll.

P.S.
Detail, Joomla 3 has "fancy select" in several filters and in my opinion it is better than Joomla 4 in this requirement. By the way, I don't know why and for what, this useful feature was removed from various system filters, , like the one I mentioned before, for example.

This pull request has been automatically rebased to 5.0-dev.

This pull request has been automatically rebased to 5.1-dev.

I have tested this item ✅ successfully on fe5dc1e

This pull request has been automatically rebased to 5.2-dev.

I have been looking around and it looks like we have the same kind of problematic in other filters (like the menu item filters).
It also introduces a visual issue for menuitem:

There is no 'heading' for the first group of options.
So the fancy select layout should not have a choice__heading layer if there is no content. Or being hidden...

while we are using a very outdated version of choices.js all this discussion is pretty pointless.

This pull request has been automatically rebased to 5.3-dev.