Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39450] - [4.2] Minor patch for the currentModal

? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
19 Dec 2022

Pull Request for Issue # .

Summary of Changes

  • The current code saves the open modal reference to Joomla.current instead of Joomla.Modal.current
  • The current code works as the Joomla.current is not referenced by any other API, but it shouldn't be used for the modals

Testing Instructions

  • Create a new article and test adding an intro and a full image, selecting a user for the article and try using the XTD-buttons (insert Article, Menu, Module, Media).
  • All modals open and close correctly

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 19 Dec 2022
Category ⇒ JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - open - 19 Dec 2022
avatar dgrammatiko dgrammatiko - change - 19 Dec 2022
Status New ⇒ Pending
avatar Fedik
Fedik - comment - 19 Dec 2022

Please update also the incorrect comment

joomla-cms/build/media_source/system/js/core.es6.js

Lines 114 to 118 in 6cd61cb

* USAGE (assuming that exampleId is the modal id)
* To get the current modal element:
* Joomla.Modal.current; // Returns node element, eg: document.getElementById('exampleId')
* To set the current modal element:
* Joomla.Modal.setCurrent(document.getElementById('exampleId'));

It should be used Joomla.Modal.getCurrent().

avatar dgrammatiko dgrammatiko - change - 19 Dec 2022
Labels Added: NPM Resource Changed ?
avatar dgrammatiko
dgrammatiko - comment - 19 Dec 2022

@Fedik done

avatar carlitorweb
carlitorweb - comment - 7 Jan 2023

Remember for the other tester use after apply the patch, npm run build:js

avatar carlitorweb carlitorweb - test_item - 7 Jan 2023 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 7 Jan 2023

I have tested this item ✅ successfully on 385efc0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39450.

avatar Quy Quy - test_item - 9 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 9 Jan 2023

I have tested this item ✅ successfully on 385efc0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39450.

avatar Quy Quy - change - 9 Jan 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 9 Jan 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39450.

avatar roland-d roland-d - change - 10 Jan 2023
Labels Added: ?
avatar fancyFranci fancyFranci - change - 10 Jan 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-01-10 22:09:08
Closed_By ⇒ fancyFranci
avatar fancyFranci fancyFranci - close - 10 Jan 2023
avatar fancyFranci fancyFranci - merge - 10 Jan 2023
avatar fancyFranci
fancyFranci - comment - 10 Jan 2023

Thanks for cleaning this up!

Add a Comment

Login with GitHub to post a comment