No Code Attached Yet
avatar coolcat-creations
coolcat-creations
18 Dec 2022

Steps to reproduce the issue

Go for example into the issue https://ci.joomla.org/artifacts/joomla/joomla-cms/4.2-dev/39443/downloads/60210/ and download the prebuild package Joomla_4.2.x_to_4.2.7-dev+pr.39443-Development-Patch_Package.zip

In your Joomla test environment on Joomla 4.2.4 (or higher) go into the Joomla Updater and install the downloaded package.

Expected result

The package updates your Joomla Version with the patch

Actual result

Not only with this PR but also with another one I had first this screen. I tested it on three different sites and on two different servers.

Bildschirmfoto 2022-12-18 um 12 11 51

and afterwards a message that the update went successful:
Screenshot 2022-12-18 at 12-12-08 Upload   Update - Your Joomla! Site hosted with CloudAccess net - Administration

But nothing was installed actually.

System information (as much as possible)

I am not sure if this is a

  • user issue (did I confuse something?)
  • or a prebuilt package issue
  • or a Joomla issue
avatar coolcat-creations coolcat-creations - open - 18 Dec 2022
avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Dec 2022
avatar richard67
richard67 - comment - 18 Dec 2022

@coolcat-creations If you are not sure if it's a user issue or issue with the package or the MCS, why do you the use a title "Joomla 4.2.4+ Patch Upload / Update Bug" which clearly implements it's a bug in the CMS? I have told you before that you should maybe check the definition of the word "bug" in software context.

avatar crystalenka
crystalenka - comment - 18 Dec 2022

@richard67

  • usability bugs are also valid bugs
  • user error is often because of a usability bug
  • is the problem the verbiage or the issue she's experiencing?
avatar richard67
richard67 - comment - 18 Dec 2022

@coolcat-creations Regarding the issue: You need to download the https://ci.joomla.org/artifacts/joomla/joomla-cms/4.2-dev/39443/downloads/60210/Joomla_4.2.7-dev+pr.39443-Development-Update_Package.zip . The patch packages 4.2.6 to 4.2.6 or 4.2.x to 4.2.7 are know to be incomplete regarding assets in the media folder. That means if you have a PR which only changes scss or js, if can be that there is nothing in the package. You can also use the custom update URL for a live update, that also installs the package which works and which I have mentioned first.

avatar richard67
richard67 - comment - 18 Dec 2022

@richard67

* usability bugs are also valid bugs

* user error is often because of a usability bug

* is the problem the verbiage or the issue she's experiencing?

Read the title of this issue again. It says there is a bug where the description says that it's not clear yet where the bug is, and so it anticipates the result of the investigation which has to be done.

In fact the bug is not in the patch upload but in the fact that we still build the 4.2.6 to 4.2.7 or 4.2.x to 4.2.7 patch packages for nightly builds and for pull requests (but not for releases) while we know that these packages are incomplete because they do not include changes in the media or the vendor folder.

So please when making a title for an issue, try to summarize the issue and not the possible reason which has not been investigated yet.

avatar richard67
richard67 - comment - 18 Dec 2022

@coolcat-creations Could you check and report back if it works for the PR you have mentioned in the description when you use the update package https://ci.joomla.org/artifacts/joomla/joomla-cms/4.2-dev/39443/downloads/60210/Joomla_4.2.7-dev+pr.39443-Development-Update_Package.zip or the custom update URL https://ci.joomla.org/artifacts/joomla/joomla-cms/4.2-dev/39443/downloads/60210/pr_list.xml ? Thanks in advance.

avatar richard67
richard67 - comment - 18 Dec 2022

We will meanwhile fix the package build for the PRs so the questionable packages will not be built anymore in future. It had been fixed once in past, if I remember right, but somehow that got lost.

avatar richard67
richard67 - comment - 18 Dec 2022

So regardless of my little complaint about the title, thanks for reporting.

avatar coolcat-creations
coolcat-creations - comment - 18 Dec 2022

Custom Update URL works as expected because thats what @crystalenka did to fix the missing patch on one of the test sites. The proposed package https://ci.joomla.org/artifacts/joomla/joomla-cms/4.2-dev/39443/downloads/60210/Joomla_4.2.7-dev+pr.39443-Development-Update_Package.zip works as well.

In fact the bug is not in the patch upload but in the fact that we still build the 4.2.6 to 4.2.7 or 4.2.x to 4.2.7 patch packages for nightly builds and for pull requests (but not for releases) while we know that these packages are incomplete because they do not include changes in the media or the vendor folder.

So there is a bug / known issue in the prebuilt packages.

We will meanwhile fix the package build for the PRs so the questionable packages will not be built anymore in future. It had been fixed once in past, if I remember right, but somehow that got lost.

Yes I would recommend to remove them if they are unusable to test.

avatar coolcat-creations coolcat-creations - change - 18 Dec 2022
Title
Joomla 4.2.4+ Patch Upload / Update Bug
Bug in Prebuilt packages
avatar coolcat-creations coolcat-creations - edited - 18 Dec 2022
avatar richard67
richard67 - comment - 18 Dec 2022

The nightly builds will not contain patch packages anymore. This has been fixed here in this repo with this commit f020637 for the 4.2-dev branch and will be merged up to 4.3-dev when the branch freeze for alpha 2 has ended.

This can be checked here: https://developer.joomla.org/nightly-builds.html . The nightly builds for 4.2 which I just have run don't include the patch packages anymore. Those for 4.3 still do.

The package build for pull requests will also not contain patch packages anymore. This has been fixed in the docker images here: joomla-projects/docker-images@3b35e8b .

It might need further steps until we can see the result on the downloads page for pull request.

Thanks @HLeithner for both fixes.

Note that this should be a temporary solution until the build of patch packages has been fixed so they can be used.

avatar coolcat-creations coolcat-creations - close - 18 Dec 2022
avatar coolcat-creations
coolcat-creations - comment - 18 Dec 2022

Ok thank you I close this issue then! :-)

avatar coolcat-creations coolcat-creations - change - 18 Dec 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-12-18 14:53:39
Closed_By coolcat-creations

Add a Comment

Login with GitHub to post a comment