? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
18 Dec 2022

Pull Request for Issue #39441

Summary of Changes

This PR disables the input of a new tag in the parent field on com_tags edit.

Testing Instructions

see #39441
Ty to add a new tag in the parent selection field.

Actual result BEFORE applying this Pull Request

see #39441

Expected result AFTER applying this Pull Request

The parent tag allows seleting a tag as parent but does not accept the input of a new tag name.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2022
Category com_tags Administration
avatar chmst chmst - open - 18 Dec 2022
avatar chmst chmst - change - 18 Dec 2022
Status New Pending
avatar richard67 richard67 - change - 18 Dec 2022
Labels Added: ?
avatar brianteeman
brianteeman - comment - 18 Dec 2022

Not sure this is quite correct.

If you look at the category selector in com_categories and enter a non-existant category as the parent you can not - pressing enter that this point does nothing
image

But even with this pr when you do the same in tags then pressing enter will appear to create the tag except its not saved.
image

avatar chmst
chmst - comment - 19 Dec 2022

Agree, The tag field should behave like the categoryedit field. At the moment it os not clear how the categoryedit field should work see #39440.
This is a quick fix to resolve the ugly error message,

I don't mind to close this one and re-open the issue. Unfortunately don't have time for diving deeper into nested set.

avatar joomdonation joomdonation - test_item - 8 Jan 2023 - Not tested
avatar joomdonation joomdonation - test_item - 8 Jan 2023 - Tested successfully
avatar joomdonation
joomdonation - comment - 8 Jan 2023

I have tested this item successfully on 922e402

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39443.

avatar Quy Quy - test_item - 9 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 9 Jan 2023

I have tested this item successfully on 922e402


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39443.

avatar Quy Quy - change - 9 Jan 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 9 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39443.

avatar fancyFranci fancyFranci - change - 10 Jan 2023
Labels Added: ?
avatar fancyFranci fancyFranci - close - 10 Jan 2023
avatar fancyFranci fancyFranci - merge - 10 Jan 2023
avatar fancyFranci fancyFranci - change - 10 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-10 22:51:26
Closed_By fancyFranci
avatar fancyFranci
fancyFranci - comment - 10 Jan 2023

Great, thank you!

Add a Comment

Login with GitHub to post a comment