? ? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Dec 2022

I was testing a script using the joomla repo and found these typos/grammar errors.

The basic english language rule is that if you want to write "a something" and the "something" begins with a vowel then it changes to "an"

This also applies even if the "something" sounds like it begins with a vowel.

As these are all corrections in comments testing is just by review

avatar joomla-cms-bot joomla-cms-bot - change - 16 Dec 2022
Category JavaScript Repository NPM Change Libraries Unit Tests
avatar brianteeman brianteeman - open - 16 Dec 2022
avatar brianteeman brianteeman - change - 16 Dec 2022
Status New Pending
avatar sandewt sandewt - test_item - 16 Dec 2022 - Tested successfully
avatar sandewt
sandewt - comment - 16 Dec 2022

I have tested this item successfully on 52d7ce0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39432.

avatar Quy Quy - test_item - 16 Dec 2022 - Tested successfully
avatar Quy
Quy - comment - 16 Dec 2022

I have tested this item successfully on 52d7ce0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39432.

avatar Quy Quy - change - 16 Dec 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 16 Dec 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39432.

avatar roland-d roland-d - change - 17 Dec 2022
Labels Added: ?
avatar richard67 richard67 - change - 17 Dec 2022
Labels Added: ? NPM Resource Changed
avatar roland-d roland-d - close - 17 Dec 2022
avatar roland-d roland-d - merge - 17 Dec 2022
avatar roland-d roland-d - change - 17 Dec 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-12-17 22:38:36
Closed_By roland-d
avatar roland-d
roland-d - comment - 17 Dec 2022

Thank you

avatar richard67
richard67 - comment - 17 Dec 2022

@roland-d I know it’s only grammar in comments, but have you seen my review comment?

avatar brianteeman
brianteeman - comment - 17 Dec 2022

@roland-d I know it’s only grammar in comments, but have you seen my review comment?

??

avatar roland-d
roland-d - comment - 17 Dec 2022

@richard67 I only see that you merged 4.2-dev branch into here. There is nothing else.

avatar richard67
richard67 - comment - 17 Dec 2022

Ah i see the review was pending.

avatar richard67
richard67 - comment - 17 Dec 2022

Can you see it now? Review was pending still, my mistake.

avatar roland-d
roland-d - comment - 17 Dec 2022

Now it is visible.

Add a Comment

Login with GitHub to post a comment