[#39409] - [4.2] Media manager improvements
- Fixed in Code Base
- 28 Dec 2022
- Medium
- Build: 4.2-dev
- # 39409
- Diff
- dgrammatiko:4.2-dev_improve_mm
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- add another script in the list of package.json scripts for compiling MM for development (dev tools friendly)
- add the package
dotenvthat is required for the above - replace the abandoned vuex-persistedstate with vuex-persist
- minor CS on the entry of the app
Testing Instructions
- Run the commands
npm ci,npm run build:com_mediaandnpm run build:com_media:devand verify that media manager works on all of them - Create an article and select an intro image (preferably one that is inside a deep nested folder)
- Observe that the localSession has a value for the
joomla.mediamanager - Try to select an image for the full image input and verify that the media manager opened in the previous selected folder (ie the one you chose for the intro image)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
The new command is documented in the build/README.md
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change Repository |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
I was not sure about the sequence to apply the npm commands - but the media manager worked after npm ci and after npm ci + both others. I could see local session change as different folders were selected. The full image folder opened either with the folder containing the existing image or with the folder from the session storage - is that right. Complicated, but I could not see anything wrong.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39409.
@ceford thanks for testing this.
Complicated,
Yeah it's weird but somehow we needed to keep in memory the state of the last visited folder and localSession was a good solution. FWIW I'm not changing anything in the logic of the media manager here, I'm just swapping a plugin for another one
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39409.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39409.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-28 17:39:37 |
| Closed_By | ⇒ | wilsonge |
We definitely need to swap the persistence plugin out. I also think @laoneo probably should give this a good test against DP Media :)