Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39405] - [4.2] Media Manager should delete the right files

? Release Blocker NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
12 Dec 2022

Pull Request for Issue #39226 .

Summary of Changes

Take into account the search state when deleting files

Testing Instructions

Follow the instructions on the issue

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Kudos to @fancyFranci for this one

avatar joomla-cms-bot joomla-cms-bot - change - 12 Dec 2022
Category ⇒ JavaScript Administration com_media NPM Change
avatar dgrammatiko dgrammatiko - open - 12 Dec 2022
avatar dgrammatiko dgrammatiko - change - 12 Dec 2022
Status New ⇒ Pending
avatar brianteeman
brianteeman - comment - 12 Dec 2022

To testers. If you are not running a pre-built package you will need to run


npm run build:com_media
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/39405">issues.joomla.org/tracker/joomla-cms/39405</a>.</sub>
avatar brianteeman brianteeman - test_item - 12 Dec 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Dec 2022

I have tested this item ✅ successfully on 8d0d501

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39405.

avatar dgrammatiko
dgrammatiko - comment - 12 Dec 2022

@Hackwar could you check why the drone is returning an exit code 0 when the same command in a normal terminal (eslint ...) will return -1?
Screenshot 2022-12-13 at 00 20 32

BTW the reported issue is irrelevant with the code in this PR

avatar richard67 richard67 - test_item - 13 Dec 2022 - Tested successfully
avatar richard67
richard67 - comment - 13 Dec 2022

I have tested this item ✅ successfully on 8d0d501

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39405.

avatar richard67 richard67 - change - 13 Dec 2022
Status Pending ⇒ Ready to Commit
Labels Added: NPM Resource Changed Release Blocker ?
avatar richard67
richard67 - comment - 13 Dec 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39405.

avatar fancyFranci fancyFranci - change - 13 Dec 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-12-13 12:09:49
Closed_By ⇒ fancyFranci
Labels Added: ?
avatar fancyFranci fancyFranci - close - 13 Dec 2022
avatar fancyFranci fancyFranci - merge - 13 Dec 2022
avatar fancyFranci
fancyFranci - comment - 13 Dec 2022

That was really fast! Thank you very much

Add a Comment

Login with GitHub to post a comment