? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
8 Dec 2022

Pull Request for Issue # .

Summary of Changes

  • Atum

  • Installation

  • Cassiopeia

Testing Instructions

Check that all 3 templates (installation/Atum/Cassiopeia) don't have any visual of functional regression

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

For the Bootstrap changes refer to the Bootstrap Docs

d2a0c8a 8 Dec 2022 avatar dgrammatiko init
avatar joomla-cms-bot joomla-cms-bot - change - 8 Dec 2022
Category Repository NPM Change Installation Front End Templates (site)
avatar dgrammatiko dgrammatiko - open - 8 Dec 2022
avatar dgrammatiko dgrammatiko - change - 8 Dec 2022
Status New Pending
avatar dgrammatiko dgrammatiko - change - 8 Dec 2022
Labels Added: NPM Resource Changed PR-4.3-dev
avatar dgrammatiko dgrammatiko - change - 8 Dec 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 8 Dec 2022
avatar dgrammatiko dgrammatiko - change - 8 Dec 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 8 Dec 2022
avatar dgrammatiko dgrammatiko - change - 8 Dec 2022
Title
[WIP] Upgrade to Bootstrap 5.2
[4.3] Upgrade to Bootstrap 5.2
avatar dgrammatiko dgrammatiko - edited - 8 Dec 2022
avatar dgrammatiko dgrammatiko - change - 8 Dec 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 8 Dec 2022
e95be7c 8 Dec 2022 avatar dgrammatiko Font
avatar dgrammatiko dgrammatiko - change - 8 Dec 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 8 Dec 2022
avatar brianteeman
brianteeman - comment - 8 Dec 2022

Tested that it compiles correctly

Tested cassiopeia and atum and the main (only one so far) difference is the colours.

You can see this on the typography page in the sample data with cassiopeia

Before w/BS5.1

image

After w/BS5.2

image

You can see this easily on the category list page in Atum

Before w/BS5.1

image

After w/BS5.2

image

412e1d6 9 Dec 2022 avatar dgrammatiko CS
avatar alikon
alikon - comment - 9 Dec 2022

i've done some testing, install , front, back etc
i was unable to discover glitch

avatar alikon alikon - test_item - 9 Dec 2022 - Tested successfully
avatar alikon
alikon - comment - 9 Dec 2022

I have tested this item successfully on 339f3d8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379.

avatar brianteeman
brianteeman - comment - 9 Dec 2022

found another color issue in the admin as seen on the hits column
badge bg-info calculated color is rgb (13, 202, 240)

before the calculated color was rgb(42, 105, 184)

avatar dgrammatiko
dgrammatiko - comment - 10 Dec 2022

@brianteeman I manually patched the colour but I left a TODO comment in the variables.scss to investigate why the rgb colour is different (I have a bad flu the last few days so not very easy to do anything meaningful).

4373a97 10 Dec 2022 avatar dgrammatiko CS
avatar brianteeman
brianteeman - comment - 10 Dec 2022

ok - i actually had the same problem on my own template last night. took me ages to work out that info-rgb was numbers only

57620f6 13 Dec 2022 avatar dgrammatiko upd
avatar Quy
Quy - comment - 13 Dec 2022

39379-install

39379-browse

avatar dgrammatiko
dgrammatiko - comment - 17 Dec 2022

A short explanation for the last few lines added on both templates:

  • Bootstrap 5.2 is creating an rgb (numerical only) css var for each of the main colours (primary, secondary, info, etc)
  • These values are used from the utilities to create the borders, text color and some background-colors
  • looks like this:
.border-primary {
  --border-opacity: 1;
  border-color: rgba(var(--primary-rgb), var(--border-opacity)) !important;
}
  • since all the opacity values are 1 we can simply use the original var(--primary) instead of building the value at run time, so the previous is the same as:
.border-primary {
  border-color:var(--primary-rgb) !important;
}

Only side effect is that you cannot change the opacity and somehow affect those values anymore (you couldn't anyway before 5.2!).

f140cce 17 Dec 2022 avatar dgrammatiko cs
56a3f33 19 Dec 2022 avatar dgrammatiko cs
avatar Quy
Quy - comment - 19 Dec 2022

Font is visually different.

Without PR:

"Roboto",-apple-system,BlinkMacSystemFont,"Segoe UI","Helvetica Neue",Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"

With PR:

system-ui,-apple-system,"Segoe UI",Roboto,"Helvetica Neue","Noto Sans","Liberation Sans",Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"
avatar dgrammatiko
dgrammatiko - comment - 19 Dec 2022

@Quy which template and what settings?

avatar Quy
Quy - comment - 19 Dec 2022

Sorry it is for Atum using the prebuilt package.

avatar dgrammatiko
dgrammatiko - comment - 19 Dec 2022

@Quy good catch, should be ok now

1cfeb5d 19 Dec 2022 avatar dgrammatiko cs
avatar Quy
Quy - comment - 5 Jan 2023

Before:
tabs-before

After (color lighter):
tabs-after

Before (shadow):
table-header-before
After (no shadow):
table-header-after

avatar Hackwar
Hackwar - comment - 5 Jan 2023

Taking the current snapshot from your branch, the color of the headings in the sampledata module is lighter.

avatar Hackwar
Hackwar - comment - 5 Jan 2023

The titles of the modules on the main dashboard don't have a line below them. I noticed it with installed testing sample data at the popular articles module.

avatar Hackwar
Hackwar - comment - 5 Jan 2023

rounded corners at buttons and form elements have a bigger radius than before.

avatar dgrammatiko
dgrammatiko - comment - 5 Jan 2023

rounded corners at buttons and form elements have a bigger radius than before.

This is a change in the BS, in 5.1.3 the radius was defined with:
https://github.com/twbs/bootstrap/blob/1a6fdfae6be09b09eaced8f0e442ca6f7680a61e/scss/_variables.scss#L530-L535
in 5.2.x
https://github.com/twbs/bootstrap/blob/cb021439c683d9805e2864c58095b92d405e9b11/scss/_variables.scss#L494-L501

It seems that they use more breakpoints and align the values accordingly. We could force the old values but doesn't really seem the best way forward

Taking the current snapshot from your branch, the color of the headings in the sampledata module is lighter.
The titles of the modules on the main dashboard don't have a line below them. I noticed it with installed testing sample data at the popular articles module.

This comes again from upstream, I will pass the old values to the local css variables

Screenshot 2023-01-05 at 12 39 06

avatar Hackwar
Hackwar - comment - 5 Jan 2023

Sorry with the spam from earlier. I've combined all issues in this comment. This is a full review of frontend, backend and installation. All tested with installed testing sampledata.

Installation

I couldn't see a real difference here.

Backend

  • The color of the headings in the sampledata module is lighter.
  • The titles of the modules on the main dashboard don't have a line below them. I noticed it at the popular articles module.
  • rounded corners at buttons and form elements have a bigger radius than before.
  • When editing an article the "Save & Close" button is wider
  • there is a gap below the tabs headings when editing an article.
  • readonly form inputs are not properly styled. When editing an article, the modified by field should have a grey background, but it looks like all other input fields. The field is correctly set to readonly.
  • Looking at the permissions tab in articles, it looks like the thead block doesn't have the thicker line below it or maybe that is a shadow?

Besides these minor issues, the backend looks very good. ?

Frontend (Cassiopeia)

  • The header block is narrower
  • Here we also have the issue of the changed radius of rounded corners.

Besides these issues, the frontend also looks pretty good. ?

Looking forward to giving this a successfull test. ?

avatar dgrammatiko
dgrammatiko - comment - 5 Jan 2023

@Hackwar thanks for the testing, let me know if I've got everything:

  • The color of the headings in the sampledata module is lighter. FIXED
  • The titles of the modules on the main dashboard don't have a line below them. I noticed it at the popular articles module. FIXED
  • rounded corners at buttons and form elements have a bigger radius than before. FIXED
  • When editing an article the "Save & Close" button is wider: NOT fixed, it's a 1px difference
  • there is a gap below the tabs headings when editing an article. FIXED
  • readonly form inputs are not properly styled. When editing an article, the modified by field should have a grey background, but it looks like all other input fields. The field is correctly set to readonly. FIXED
  • Looking at the permissions tab in articles, it looks like the thead block doesn't have the thicker line below it or maybe that is a shadow? FIXED
  • The header block is narrower FIXED
  • Here we also have the issue of the changed radius of rounded corners. FIXED
a65ecd6 5 Jan 2023 avatar dgrammatiko CS
avatar Hackwar
Hackwar - comment - 6 Jan 2023

Backend

  • Dashboard: While the lines are now present, the line below the title of the sample data module is too thick, while the line below the table header of the latest action module is not thick enough.
  • On list views (article list view) there is a line above the table header which is missing here and the line below the table header is too thin.

Frontend (Cassiopeia)

  • The header block is now wider than before and menu and title are jumping slightly apart and to the right.

The "Save & Close" button now looks right. It was very different before. Idk what happened.

avatar dgrammatiko
dgrammatiko - comment - 6 Jan 2023

the line below the title of the sample data module is too thick Fixed

while the line below the table header of the latest action module is not thick enough.

Both 4.2 and this PR have the same CSS rule here:

.table thead {
    border-bottom: 2px solid #dee2e6;
}

On list views (article list view) there is a line above the table header which is missing here and the line below the table header is too thin. FIXED

The header block is now wider than before and menu and title are jumping slightly apart and to the right. FIXED

avatar Hackwar
Hackwar - comment - 9 Jan 2023

I've updated the branch to the latest changes in 4.3-dev. Going to check this again now.

Regarding the line: I'm just comparing a default 4.3-dev with your branch it that looks different there.

avatar Hackwar
Hackwar - comment - 9 Jan 2023

Ok, it is almost all fixed. ? The CSS for kbd-tags is different and seems to be smaller. I could live with that if that is the default of BS. You can see that on the backend dashboard at the bottom with the keyboard shortcuts.

Anyway, I'm giving this a thumbs up.

avatar Hackwar Hackwar - test_item - 9 Jan 2023 - Tested successfully
avatar Hackwar
Hackwar - comment - 9 Jan 2023

I have tested this item successfully on a65ecd6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379.

avatar dgrammatiko
dgrammatiko - comment - 9 Jan 2023

@Hackwar the kbd should be fixed with d93370c

A big thank you for the tests here ?

avatar Hackwar Hackwar - test_item - 9 Jan 2023 - Tested successfully
avatar Hackwar
Hackwar - comment - 9 Jan 2023

I have tested this item successfully on a65ecd6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379.

avatar laoneo laoneo - test_item - 9 Jan 2023 - Tested successfully
avatar laoneo
laoneo - comment - 9 Jan 2023

I have tested this item successfully on a65ecd6

Tested it with a couple of extensions like DPCalendar or Akeeba backup


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379.

avatar Hackwar
Hackwar - comment - 9 Jan 2023

Setting to RTC.

avatar Quy Quy - change - 9 Jan 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 9 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379.

avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2023
Category Repository NPM Change Installation Front End Templates (site) Repository NPM Change Installation
avatar obuisard obuisard - change - 10 Jan 2023
Labels Added: ?
avatar obuisard obuisard - change - 11 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-11 00:12:51
Closed_By obuisard
avatar obuisard obuisard - close - 11 Jan 2023
avatar obuisard obuisard - merge - 11 Jan 2023
avatar obuisard
obuisard - comment - 11 Jan 2023

Thank you so much Dimitris @dgrammatiko for this PR.

Add a Comment

Login with GitHub to post a comment