? Documentation Required PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
7 Dec 2022

Pull Request for Issue zero-24/plg_system_httpheader#43 (comment)

Summary of Changes

Adding support to the NEL header to the core httpheaders plugin
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/NEL

Testing Instructions

  • Verify that you cant add a "NEL" header
  • apply the patch
  • confirm you can set the NEL header now

Actual result BEFORE applying this Pull Request

No support for the NEL header

Expected result AFTER applying this Pull Request

Now we do support the NEL header

Link to documentations

Please select:

avatar joomla-cms-bot joomla-cms-bot - change - 7 Dec 2022
Category Front End Plugins
avatar zero-24 zero-24 - open - 7 Dec 2022
avatar zero-24 zero-24 - change - 7 Dec 2022
Status New Pending
avatar zero-24 zero-24 - change - 8 Dec 2022
Labels Added: ?
avatar richard67
richard67 - comment - 8 Dec 2022

Shouldn't that be for 4.3-dev as it's a new feature?

avatar zero-24
zero-24 - comment - 8 Dec 2022

Shouldn't that be for 4.3-dev as it's a new feature?

A "New feature" tbh I dont think it has to go into 4.3-dev but I'm happy to move it around as soon as 4.3-dev is up-to-date with 4.2-dev branch so i can actually move it around :D

avatar Quy Quy - test_item - 30 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 30 Jan 2023

I have tested this item successfully on f29682d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39378.

avatar viocassel viocassel - test_item - 3 Feb 2023 - Tested successfully
avatar viocassel
viocassel - comment - 3 Feb 2023

I have tested this item successfully on f29682d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39378.

avatar richard67 richard67 - change - 3 Feb 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 3 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39378.

avatar fancyFranci
fancyFranci - comment - 3 Feb 2023

Please move that to 4.3-dev again. Maybe it is not a new feature, but it is not fixing wrong behaviour too :)

avatar obuisard obuisard - change - 3 Feb 2023
Labels Added: ? PR-4.3-dev
Removed: ?
avatar obuisard obuisard - change - 3 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-03 22:14:52
Closed_By obuisard
Labels Added: Documentation Required
avatar obuisard obuisard - close - 3 Feb 2023
avatar obuisard obuisard - merge - 3 Feb 2023
avatar obuisard
obuisard - comment - 3 Feb 2023

Thank you for the PR Tobias @zero-24

Add a Comment

Login with GitHub to post a comment