[#39374] - [4.3] Massmail: Fix validation
- Closed
- 13 Dec 2022
- Medium
- Build: 4.3-dev
- # 39374
- Diff
- Hackwar:4.3-massmail-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #33450.
Summary of Changes
Please see the original issue for the problem. Simply said, the mass mail feature has a custom, stupid form validation. This PR uses the default Joomla validation and also the default markup.
Testing Instructions
- Go to mass mail in the users menu.
- Click on "Send Mail" (without filling out any data)
Actual result BEFORE applying this Pull Request
The form is not send and you get a blue box stating an error. Clicking again will add yet another blue box each time.
Expected result AFTER applying this Pull Request
Sending the form is prevented and all invalid fields are marked red. In addition, there is a message at the top. Clicking again will re-validate and only display one message at the top.
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: joomla/Manual#68
joomla-cms-bot
- | Category | ⇒ | Administration com_users Language & Strings JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39374.
The deleted JS file will be added to the list of files to be deleted on update in script.php with another PR. I will care for that.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39374.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39374.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-13 11:01:04 |
| Closed_By | ⇒ | obuisard |
Documentation PR is wrong because it misses the removed JS file... this PR should have not been merged with a wrong documentation PR, also the documentation PR has to be merged at the same time as the PR it self....
Are you saying that we can't remove the JS? Or just to extend the documentation PR?
Add padding/spacing.