Feeling Lucky
NPM Resource Changed
PR-4.3-dev
[#39370] - Added title to awesomplete results list
- Closed
- 6 Dec 2022
- Medium
- Build: 4.3-dev
- # 39370
- Diff
- JackKellyUK:awesomplete-accessibility-fix
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
- Failure continuous-integration/drone/pr Build is failing Details
User tests: Successful: Unsuccessful:
Summary of Changes
Awesomplete is raising a Serious issue in axe for a missing title / aria-label attribute.
Added title attribute to results list.
There is an open issue about this, a fix looks to be implemented with the listLabel property, but it is currently unreleased.
Testing Instructions
- Setup
Smart Search > Searchmenu item (Smart Search > Search Suggestionsglobal setting must be enabled) - Run axe browser plugin / find awesomplete list ul and check for title / aria-label attribute
Actual result BEFORE applying this Pull Request
No title / aria-label attribute present on Awesomplete list
Expected result AFTER applying this Pull Request
Title attribute present on Awesomplete list
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-06 18:58:22 |
| Closed_By | ⇒ | JackKellyUK | |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||