? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
6 Dec 2022

Summary of Changes

In #33263 we introduced the concept of having a dynamic namespace map in memory in case the directory was unwriteable. However in some cases if the directory isn't writeable we actually return false from File::write instead of throwing an exception.

This allows us to use the namepsace map in that case too. Honestly I have no clue how to reproduce this other than look at doc blocks as it's as I've been setting up my new laptop. I would assume something like having the write file permissions but the wrong owner of the files (I'm still to debug why PHP can't write to the directory :) )

Either way no functionality is changed on the configuration - I've just shared the two parts to a common method and added more specific logging when you reach either fallback method.

Now to keep debugging my setup :D

Probably the only sane test to do is to ensure the file is still being written in a regular working setup!

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar wilsonge wilsonge - open - 6 Dec 2022
avatar wilsonge wilsonge - change - 6 Dec 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Dec 2022
Category Libraries
avatar wilsonge wilsonge - change - 6 Dec 2022
The description was changed
avatar wilsonge wilsonge - edited - 6 Dec 2022
avatar wilsonge wilsonge - change - 6 Dec 2022
Labels Added: ?
avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 5.0-dev.

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
Use cached namespace map when no permissions to write to the cache dir
[5.2] Use cached namespace map when no permissions to write to the cache dir
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
[5.2] Use cached namespace map when no permissions to write to the cache dir
[5.3] Use cached namespace map when no permissions to write to the cache dir
avatar HLeithner HLeithner - edited - 2 Sep 2024

Add a Comment

Login with GitHub to post a comment