? ? Pending

User tests: Successful: Unsuccessful:

avatar cyrezdev
cyrezdev
5 Dec 2022

Pull Request for Issue reported here: #39353 (comment)

Summary of Changes

  • Use branchSingular for select optgroup labels in admin filter Content Map.

Testing Instructions

  • Use another language than en-GB.
  • After Patch applied, optgroup labels are translated in your language.

Actual result BEFORE applying this Pull Request

Admin language used: de-DE

before

Expected result AFTER applying this Pull Request

Admin language used: de-DE

after

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 5 Dec 2022
Category Administration com_finder
avatar cyrezdev cyrezdev - open - 5 Dec 2022
avatar cyrezdev cyrezdev - change - 5 Dec 2022
Status New Pending
avatar cyrezdev
cyrezdev - comment - 5 Dec 2022

@Kostelano This PR fixes the issue you reported in content map filter ;-)

avatar Kostelano Kostelano - test_item - 5 Dec 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 5 Dec 2022

I have tested this item successfully on 56c6638

Thanks, it works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39359.

avatar viocassel viocassel - test_item - 6 Dec 2022 - Tested successfully
avatar viocassel
viocassel - comment - 6 Dec 2022

I have tested this item successfully on 56c6638


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39359.

avatar richard67 richard67 - change - 6 Dec 2022
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 6 Dec 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39359.

avatar richard67 richard67 - test_item - 6 Dec 2022 - Tested successfully
avatar richard67
richard67 - comment - 6 Dec 2022

I have tested this item successfully on 56c6638

After having set it to RTC, I have tested again to make sure it was no mistake.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39359.

avatar cyrezdev
cyrezdev - comment - 6 Dec 2022

Thank you @Kostelano @viocassel for testing!

After having set it to RTC, I have tested again to make sure it was no mistake.

Thank you @richard67 ?

avatar fancyFranci fancyFranci - change - 18 Dec 2022
Labels Added: ?
avatar fancyFranci fancyFranci - change - 19 Dec 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-12-19 11:09:25
Closed_By fancyFranci
avatar fancyFranci fancyFranci - close - 19 Dec 2022
avatar fancyFranci fancyFranci - merge - 19 Dec 2022
avatar fancyFranci
fancyFranci - comment - 19 Dec 2022

Thanks a lot!

Add a Comment

Login with GitHub to post a comment