? ? Maintainers Checked Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
5 Dec 2022

Fixes #39346.

Summary of Changes

This PR fixes wrong link generated by Language Switcher module for contact category association. Please look at #39346 to understand the issue.

Testing Instructions

  1. Setup a sample multilingual website using Joomla 4.2
  2. Follow the instructions at #39346 , confirm the issue.
  3. Apply patch, confirm the issue fixed.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 5 Dec 2022
Category Administration com_categories
avatar joomdonation joomdonation - open - 5 Dec 2022
avatar joomdonation joomdonation - change - 5 Dec 2022
Status New Pending
avatar joomdonation joomdonation - change - 5 Dec 2022
Labels Added: ?
avatar brianteeman brianteeman - test_item - 5 Dec 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Dec 2022

I have tested this item successfully on 534b67e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39358.

avatar viocassel viocassel - test_item - 5 Dec 2022 - Tested successfully
avatar viocassel
viocassel - comment - 5 Dec 2022

I have tested this item successfully on 534b67e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39358.

avatar richard67 richard67 - change - 5 Dec 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 5 Dec 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39358.

avatar robbiejackson
robbiejackson - comment - 5 Dec 2022

I couldn't find a Test This button, but I confirm that this fixes the issue 39346 I raised, and works well too as a solution for 3rd party components. In the case of the Joomla MVC tutorial all that the override of the getCategoryRoute method did here was add in the &lang= parameter into the query.

Just as an incidental query, is there a particular reason why this CategoryAssociationHelper class is marked as abstract?

avatar joomdonation
joomdonation - comment - 5 Dec 2022

Just as an incidental query, is there a particular reason why this CategoryAssociationHelper class is marked as abstract?

I guess it is defined like that to prevent us from instantiate object of that class. It only contains one static method, so there is no reason to create object of that class (I'm unsure if that's the right reason).

avatar roland-d roland-d - change - 17 Dec 2022
Labels Added: ? Maintainers Checked
avatar roland-d roland-d - change - 17 Dec 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-12-17 21:17:56
Closed_By roland-d
avatar roland-d roland-d - close - 17 Dec 2022
avatar roland-d roland-d - merge - 17 Dec 2022
avatar roland-d
roland-d - comment - 17 Dec 2022

Thank you.

Add a Comment

Login with GitHub to post a comment