[#39358] - Fix contact category association
- Fixed in Code Base
- 17 Dec 2022
- Medium
- Build: 4.2-dev
- # 39358
- Diff
- joomdonation:fix_contact_category_association
User tests: Successful: Unsuccessful:
Fixes #39346.
Summary of Changes
This PR fixes wrong link generated by Language Switcher module for contact category association. Please look at #39346 to understand the issue.
Testing Instructions
- Setup a sample multilingual website using Joomla 4.2
- Follow the instructions at #39346 , confirm the issue.
- Apply patch, confirm the issue fixed.
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_categories |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39358.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39358.
I couldn't find a Test This button, but I confirm that this fixes the issue 39346 I raised, and works well too as a solution for 3rd party components. In the case of the Joomla MVC tutorial all that the override of the getCategoryRoute method did here was add in the &lang= parameter into the query.
Just as an incidental query, is there a particular reason why this CategoryAssociationHelper class is marked as abstract?
Just as an incidental query, is there a particular reason why this
CategoryAssociationHelperclass is marked as abstract?
I guess it is defined like that to prevent us from instantiate object of that class. It only contains one static method, so there is no reason to create object of that class (I'm unsure if that's the right reason).
| Labels |
Added:
?
Maintainers Checked
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-17 21:17:56 |
| Closed_By | ⇒ | roland-d |
Thank you.
I have tested this item✅ successfully on 534b67e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39358.