[#39351] - [wip] Modal Field retake
- Closed
- 15 Jan 2023
- Medium
- Build: 4.3-dev
- Draft PR
- # 39351
- Diff
- dgrammatiko:4.3-dev-modals-xss
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Repository NPM Change JavaScript Layout Libraries |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
Can I use this field in subform? If not, then that's a big problem.
yes, the idea of using a custom element as the wrapper was also because of the sub forms, this way you need 0 js to handle adding removing a field. But don’t take my word, try it yourself with either user or media fields
EDIT: Sorry @Septdir I thought this was another PR so the user/media fields are totally irrelevant here. Theoretically, this implementation should work ootb with subforms due to the fact that the field is now a Custom Element. I say theoretically because:
- the original code is not mine, I just revived the code and applied some changes so it works on 4.3
- I haven't tested that case
Sorry @dgrammatiko, unfortunately, I have my own implementation of modal fields, it is not suitable for Joomla core, because it is much more complicated and uses ajax, which allows you to add additional data to the hidden field for use in onchange and onload events.
And unfortunately, I won't be able to test this implementation of the field right now, I just don't have enough time for everything. I can only say that the most important thing is that media and modal_article work in subform.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-15 17:09:16 |
| Closed_By | ⇒ | dgrammatiko |
Can I use this field in subform? If not, then that's a big problem.