[#39345] - Updating 4.3-dev with changes from 4.2-dev
- Fixed in Code Base
- 4 Dec 2022
- Medium
- Build: 4.3-dev
- # 39345
- Diff
- sdwjoomla:upmerge-20221202
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
| Category | ⇒ | JavaScript Administration com_media NPM Change com_templates Language & Strings Repository Front End com_users Installation Layout Libraries Plugins |
changes in package.json do not look right
some packages are being removed and some others are being downgraded
changes in package.json do not look right
some packages are being removed and some others are being downgraded
Yes, and it also seems to undo Dimitris‘ move from sass to sass-embedded.
And besides that it changes package.json but not package.lock, that can’t go well.
To properly solve this mess, it needs to study the change history of the package.json in both branches 4.2-dev and 4.3-dev and check each change individually. And after that when the package lock is right it needs to remove the lock file and run npm install, or keep the lock and run npm update for the individual packages which shall be updated.
| Labels |
Added:
?
Language Change
NPM Resource Changed
PR-4.3-dev
|
||
By review the changes in package.json look ok to me. Changes from PR's #39320 and #39315 correctly merged up from 4.2-dev, and no changes for 4.3-dev got lost. The 2 mentioned PR's from 4.2-dev do not result in changes in the lock file, so it is ok that this PR here doesn't change that.
The other changes in this PR I haven't checked.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-04 16:13:59 |
| Closed_By | ⇒ | sdwjoomla |
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.