[#39325] - [4.3] Workflow Transitions
- Fixed in Code Base
- 14 Dec 2022
- Medium
- Build: 4.3-dev
- # 39325
- Diff
- brianteeman:transitions
User tests: Successful: Unsuccessful:
Recently there have been several people posting that they don't understand Workflows. I was reviewing my notes from the Workflows presentation I gave this year at JoomlaDay fr and I realised that we can easily remove one area of confusion.
Summary of Changes
Add a title to the options so that it is clear what they are for. It was confusing before because the displayed value is a stage but the options are a transition.
Bizaarely we must have realised this before because the Action button already adds some clarification by saying "Run Transitions"
NOTE: If you are using the workflow from the sample data the problems this PR fixes are more obvious
Testing Instructions
- Enable workflows
- in the article list view click on the stage
- in the article edit view click on the workflow
Actual result BEFORE applying this Pull Request
In the list view it is not clear that there are two different things in the list - current stage name and transitions
In the article view it says Workflow but it should say Workflow Stage and it is not clear that there are two different things in the list - current stage name and transitions
Expected result AFTER applying this Pull Request
Article List View
Article Edit View
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
screenshots will need updating -
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Layout Libraries |
| Title |
|
||||||
| Labels |
Added:
Language Change
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325.
I did not catch this one in time, but the TransitionField could have been modified to extend GroupediistField rather than ListField, where grouping of options is handled more elegantly and would prevent the hard coding of OPTGROUP
Do you want me to look at updating this pr with that?
Do you want me to look at updating this pr with that?
Actually, that would be great! Your code is perfectly valid, but since the core is the reference in terms of coding and use of the API, I would prefer we use the available tools we have. Thank you, Brian!
will do boss
| Labels |
Added:
?
Documentation Required
|
||
Having looked at the code I am going to pass on making the change myself and stick with my pr. Feel free of course to reject it and to submit your own.
Having looked at the code I am going to pass on making the change myself and stick with my pr. Feel free of course to reject it and to submit your own.
@brianteeman I do not want to close this PR because of the work that you put into it and the user benefits.
However, I still think the TransitionField.php should be updated.
There are 5 lines of code to modify and 2 to remove.
I can modify your file and commit the changes so we can save ourselves some time. Ok with you?
I would prefer it if you did it as a pr to my branch
I would prefer it if you did it as a pr to my branch
Ok, I can do that.
This will need you tests
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325.
Vio @viocassel, we need a new test for this updated PR, do you mind re-testing? Thank you!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-14 20:58:21 |
| Closed_By | ⇒ | obuisard |
Thank you Brian @brianteeman !
thx
@brianteeman Can you please look into this for the frontend? Thanks.
I have tested this item✅ successfully on cf92a8d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325.