[#39295] - Fix CodeMirror throwing 404 Not Found on text/html.js
- Fixed in Code Base
- 25 Nov 2022
- Medium
- Build: 4.2-dev
- # 39295
- Diff
- OctavianC:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #33542 .
Summary of Changes
When fixing #39277 this bug resurfaced...
Special handling for text/html to set the editor mode to mode.mode which is htmlmixed. Inspired from the x-php handling... I'm not familiar with how CodeMirror loads modes and why a second instance of the HTML mode would attempt to load "text/html.js" instead of "htmlmixed.js" (the parameters are the same) but this seems to do the trick.
Testing Instructions
- Set CodeMirror as default editor
- Go to Content - Fields - click New
- Set Type to Editor, add a Title and Save
- Go to Content - Articles - click New. You'll see the main content editor on the first tab and another CodeMirror editor in the Fields tab.
Actual result BEFORE applying this Pull Request
Second editor instance attempts to load text/html.js which results in a 404 Not Found
Expected result AFTER applying this Pull Request
No errors in the console
Make sure other instances are not affected: I've verified that highlighting works correctly for .css, .json, .xml, .php files when using the editor from Site Templates > Cassiopeia
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
Why not just adding ‘text/html’ to the array in line 64 instead of adding the elseif?
Why not just adding ‘text/html’ to the array in line 64 instead of adding the elseif?
Ah, forget it. Silly me. Haven’t looked close enough on my phone :-)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39295.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39295.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-25 08:11:35 |
| Closed_By | ⇒ | laoneo |
Thanks!
I have tested this item✅ successfully on 86e8d3e
Replicated bug and confirmed the fix
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39295.