Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39283] - Fix the restore behavior for legacy BS tabs

? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
23 Nov 2022

Pull Request for Issue #39271.

Summary of Changes

Fixes the tabs state script as it was not compatible with Bootstrap 5.

Added also a solution from twbs/bootstrap#34767.

Steps to reproduce the issue

Actual result BEFORE applying this Pull Request

The page reloads and the first tab is opened.

Expected result AFTER applying this Pull Request

The page is reloaded and the location tab is opened.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 23 Nov 2022
avatar laoneo laoneo - change - 23 Nov 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Nov 2022
Category ⇒ JavaScript Repository NPM Change
avatar laoneo laoneo - change - 23 Nov 2022
The description was changed
avatar laoneo laoneo - edited - 23 Nov 2022
avatar brianteeman
brianteeman - comment - 23 Nov 2022

While checking this PR I spotted an error in the existing code comments

joomla-cms/build/media_source/legacy/js/tabs-state.es5.js

Line 7 in 4bbd612

* JavaScript behavior to allow selected tab to be remained after save or page reload

This should be remembered not remained. I can create a seperate PR for this or you can add it here

avatar laoneo laoneo - change - 23 Nov 2022
Labels Added: NPM Resource Changed ?
avatar laoneo
laoneo - comment - 23 Nov 2022

@brianteeman thanks, fixed it

avatar richard67
richard67 - comment - 23 Nov 2022

@laoneo Could you close your own issue when having made a PR for it? Thanks in advance.

avatar brianteeman brianteeman - test_item - 23 Nov 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 23 Nov 2022

I have tested this item ✅ successfully on 996ec31

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39283.

avatar viocassel viocassel - test_item - 23 Nov 2022 - Tested successfully
avatar viocassel
viocassel - comment - 23 Nov 2022

I have tested this item ✅ successfully on 996ec31

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39283.

avatar richard67 richard67 - change - 23 Nov 2022
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 23 Nov 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39283.

avatar fancyFranci fancyFranci - close - 1 Dec 2022
avatar fancyFranci fancyFranci - merge - 1 Dec 2022
avatar fancyFranci fancyFranci - change - 1 Dec 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-12-01 20:40:32
Closed_By ⇒ fancyFranci
Labels Added: ?
avatar fancyFranci
fancyFranci - comment - 1 Dec 2022

Thank you for fixing that!

Add a Comment

Login with GitHub to post a comment