Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39253] - [4.3] Pre-select category for new custom field

? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
19 Nov 2022

Pull Request for Issue #38794.

Summary of Changes

This PR implement feature request described #38794 . Please look at that linked issue to understand the request.

Testing Instructions

  1. Go to Content -> Fields to manage custom fields for articles
  2. Select a category from Categories filter option.
  3. Press New button in the toolbar to create new custom field

Actual result BEFORE applying this Pull Request

On new custom field screen, the pre-selected category above is not selected. Category of the field is set to All

Expected result AFTER applying this Pull Request

On new custom field screen, the pre-selected category above is selected. Category of the field is set to the category which you selected in the filter before pressing New button

avatar joomdonation joomdonation - open - 19 Nov 2022
avatar joomdonation joomdonation - change - 19 Nov 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Nov 2022
Category ⇒ Administration com_fields
avatar brianteeman
brianteeman - comment - 19 Nov 2022

Shouldn't this be applied to all filters not just category?

avatar joomdonation
joomdonation - comment - 19 Nov 2022

@brianteeman Other filters already worked before this PR. For some reasons, category is the only field not pre-selected base on filter, and this PR just improves it.

avatar brianteeman brianteeman - test_item - 19 Nov 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 19 Nov 2022

I have tested this item ✅ successfully on 5528470

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39253.

avatar joomdonation joomdonation - change - 20 Nov 2022
Labels Added: PR-4.3-dev
avatar joomdonation joomdonation - alter_testresult - 20 Nov 2022 - brianteeman: Tested successfully
avatar joomdonation
joomdonation - comment - 20 Nov 2022

As it is a simple and obvious change, I restored @brianteeman test result so that he does not need to test again.

aeedb3a 20 Nov 2022 avatar joomdonation CS
75967e2 20 Nov 2022 avatar joomdonation CS
avatar joomdonation joomdonation - alter_testresult - 20 Nov 2022 - brianteeman: Tested successfully
avatar joomdonation joomdonation - change - 20 Nov 2022
The description was changed
avatar joomdonation joomdonation - edited - 20 Nov 2022
avatar viocassel viocassel - test_item - 20 Nov 2022 - Tested successfully
avatar viocassel
viocassel - comment - 20 Nov 2022

I have tested this item ✅ successfully on 75967e2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39253.

avatar joomdonation joomdonation - change - 20 Nov 2022
Status Pending ⇒ Ready to Commit
avatar joomdonation
joomdonation - comment - 21 Nov 2022

RTC. Thanks @brianteeman and @viocassel for testing.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39253.

avatar laoneo laoneo - change - 25 Nov 2022
Labels Added: ?
avatar laoneo laoneo - change - 25 Nov 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-11-25 09:11:25
Closed_By ⇒ laoneo
avatar laoneo laoneo - close - 25 Nov 2022
avatar laoneo laoneo - merge - 25 Nov 2022
avatar laoneo
laoneo - comment - 25 Nov 2022

Thanks!

Add a Comment

Login with GitHub to post a comment