[#39252] - Modify send email copy checkbox in contact form
- Closed
- 31 Aug 2023
- Medium
- Build: 4.2-dev
- # 39252
- Diff
- drmenzelit:mail-copy-check
User tests: Successful: Unsuccessful:
Pull Request for Issue #34757.
Probably not the best solution, but the only one a I can think at the moment.
This problem is related to #31218 and is something we need to reconsider for the next major Joomla version.
Summary of Changes
Modified the way the checkbox "send mail copy" is rendered. It uses now current Bootstrap code to display checkbox and label in a line.
Testing Instructions
See issue #34757
Actual result BEFORE applying this Pull Request
See issue #34757
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
The problem with this is that it only fixes this one field. If you have another checkbox type field on that page then you still get the problem.
From what I can tell it needs a display:inline-block on the .controls class
display:inline-block is not enough, because .controls is inside .control-group together with .control-label
If .control-group would have another unique class for the copy field, one could use display: flex ... but that is not the case, all fields have only .control-group...
If you change your condition to
<?php if ($field->type != 'Checkbox') : ?>
the form can have many checkboxes.
This pull request has been automatically rebased to 4.3-dev.
This functionally should be removed completely instead of fixing it. I close this PR since allowing the user to send emails to an arbitrary address is a security issue.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-31 15:42:19 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
bug
PR-5.0-dev
?
|
||
I have tested this item✅ successfully on 6b61bf4
Thanks, it works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39252.