? ? Success

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
18 Jul 2014

A lot of improvements to this file.

  • jQuery code should be executed in a ready function, not just a closure
  • js strings should be properly encoded
  • some restructuring to be nicer looking and more efficient
  • use a layout for complex html rendering

Tracker is here: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33966&start=0

Not all tracker issues are addressed. One in particular is maybe not possible without breaking backwards compatibility.

avatar okonomiyaki3000 okonomiyaki3000 - open - 18 Jul 2014
avatar okonomiyaki3000 okonomiyaki3000 - change - 18 Jul 2014
Title
Jhtmlbootstrap
[#33966] Jhtmlbootstrap
avatar okonomiyaki3000
okonomiyaki3000 - comment - 18 Jul 2014

And of course some tests fail because they are wrong. Hmm. I'll fix them later.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 25 Jul 2014

The tracker item has instructions for testing the functions that are easily testable with a base install of Joomla. Many of the functions in JHtmlBootstrap are not used at all but are provided (presumably) so that extensions developers can take advantage of Bootstrap's features. To test all of them, you'd need to install some extension that uses them.

avatar illovo
illovo - comment - 25 Jul 2014

Carousel tested with
JHtmlBootstrap::carousel('carousel', array('interval'=>200, 'pause'=>'hover'));
Works now as expected. Autostarts and correct interval.

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32098&start=0

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29736&start=0

avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 2 Sep 2014
Category JavaScript Layout Template
avatar roland-d
roland-d - comment - 20 Aug 2015
avatar dgt41
dgt41 - comment - 20 Aug 2015

@okonomiyaki3000 @roland-d the modal part needs some changes, as the code is already deprecated

avatar wnnz34
wnnz34 - comment - 21 Aug 2015

Hello I tested the following Feartures:

modal - Used on admin pages which have a 'batch' button that brings up a modal dialog. Tested

popover - Used on the module type select page to pop up a message with more information about each module type. Tested

tooltip - Used on most list views such as the Category Manager and Article Manager. Displays the tooltip when mousing over the column names and certain column content. Tested

startTabset (and related functions) - Used on virtually every edit page. Tested

startAccordion (and related functions) - Used in the modal dialog for menu item type selection. Tested


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3922.

avatar wnnz34 wnnz34 - test_item - 21 Aug 2015 - Tested successfully
avatar Blutengel89 Blutengel89 - test_item - 21 Aug 2015 - Tested successfully
avatar roland-d
roland-d - comment - 21 Aug 2015

@dgt41 Thank you for stepping in here. How do you propose to fix this PR? It has been tested successfully twice. Perhaps a PR against this one by @okonomiyaki3000 ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3922.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2015
Labels Added: ?
avatar okonomiyaki3000
okonomiyaki3000 - comment - 25 Aug 2015

There were some problems with the tests. I'll have a look at this deprecated modal issue.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 25 Aug 2015

@wnnz34 JHtmlBootstrap::modal is not really used for those batch buttons. The only place I can find it being used at all is in the modules view and it's completely unnecessary there. That line can be removed and the modal still works because the js code to actually create and open the modal is in the layout file.

The comment on the modal function: "JS Not working" is not correct. It works perfectly it just doesn't really do anything. It sets up the modal but never opens it (unless "show": true is part of the $params object but this will just cause the modal to open instantly on page load). So the function is kind of useless.

Sorry, off topic, but I think really all of these front-end functions are kind of stupid. This front-end stuff just be done on the front end. We don't need PHP functions to do it.

avatar roland-d
roland-d - comment - 8 Nov 2015

Hello @okonomiyaki3000

Thank you for your contribution.

The last comment here was on August 25th. Can you please follow-up?

If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3922.

avatar roland-d roland-d - change - 8 Nov 2015
Status Pending Information Required
Labels
avatar okonomiyaki3000 okonomiyaki3000 - change - 9 Nov 2015
Labels
avatar joomla-cms-bot
joomla-cms-bot - comment - 9 Nov 2015

This PR has received new commits.

CC: @Blutengel89, @wnnz34


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3922.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 9 Nov 2015

@roland-d OK, well as a follow up to myself...

Yes, @okonomiyaki3000, you are correct that the modal function (which will apparently be removed in 4.0 anyway) is no longer used anywhere. Even so, fixing it is a good idea.

I also agree with you that these back-end functions should not exist at all.

Also, I've rebased with the latest staging.

avatar brianteeman brianteeman - change - 19 Dec 2015
Status Information Required Pending
Labels
avatar roland-d roland-d - change - 8 May 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-08 14:11:53
Closed_By roland-d
Labels
avatar roland-d roland-d - reference | de1f8f3 - 8 May 16
avatar roland-d roland-d - merge - 8 May 2016
avatar roland-d roland-d - close - 8 May 2016
avatar roland-d roland-d - change - 8 May 2016
Milestone Added:
avatar infograf768
infograf768 - comment - 2 Aug 2016

Folks, see #11400
@okonomiyaki3000
@roland-d
We have an issue with strings containing single quote

Add a Comment

Login with GitHub to post a comment