[#39216] - [4.3] Unpublish testing sampledata plugin after installing data
- Closed
- 9 Jan 2023
- Medium
- Build: 4.3-dev
- # 39216
- Diff
- Hackwar:4.3-sampledata-remove
User tests: Successful: Unsuccessful:
Pull Request for Issue #23633 .
Summary of Changes
If the data from a sampledata plugin can't be installed twice, it should be unpublished after installing the data. I also added the check for the name.
Testing Instructions
Install testing sampledata.
Actual result BEFORE applying this Pull Request
Testing sampledata is still offered after installing.
Expected result AFTER applying this Pull Request
Testing sampledata vanishes from list of offered sampledata in backend.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Just applied it but it is confusing. It would be more helpful if for example the button is disabled (Personal opinion).
Sure we can directly use the table not sure whether it would make more sense to run it via the plugin save method that would also trigger other plugins etc.
But I do also get the point of @chmst maybe its worth to store "has been clicked once" within the plugin and disable the button. That makes sure we are not doing some magic in the background but let hiding that module to the user when he wishes to do that.
Dont we need similiar code to the other sampledata plugins too?
Since the other sampledata can be installed more than once (at least according to the comments from others here) it is only relevant to the testing sample data. To be honest, I could also just close this and we keep the issue closed, saying that we don't want this.
Since the other sampledata can be installed more than once (at least according to the comments from others here) it is only relevant to the testing sample data. To be honest, I could also just close this and we keep the issue closed, saying that we don't want this.
My experience was: I used testing sample data (btw. this is always my indicator for "this is my developer site ..") then activated blog sample data - error (of course). So personally would prefer to abandon the PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-09 12:01:35 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
PR-4.3-dev
|
||
Following Christianes judgement and closing this PR.
(as this doesnt get included in a distriubuted release it can be merged with any version)