Feeling Lucky
PR-4.3-dev
[#39214] - [4.3] Removing references to FoF from comments
- Fixed in Code Base
- 14 Nov 2022
- Medium
- Build: 4.3-dev
- # 39214
- Diff
- Hackwar:4.3-fof-comments
User tests: Successful: Unsuccessful:
Pull Request for Issue #36838 .
Summary of Changes
We aren't shipping Joomla with FoF anymore, so we should remove the comments from the code. The parameter to a call I removed, I removed because the called method doesn't have this parameter.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_postinstall com_users |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-14 12:51:36 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
PR-4.3-dev
|
||
laoneo
- comment
- 14 Nov 2022
Thanks!
I have tested this item✅ successfully on 6944b10
Code review. The changed comments make sense and the removal of the function parameter is right, see also https://github.com/Hackwar/joomla-cms/blob/6944b10618f98120362fc8fbce93198da5ee9ca4/libraries/src/Encrypt/Aes.php#L144 .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39214.