? Language Change PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
13 Nov 2022

Pull Request for Issue #39076 .

Summary of Changes

Revert the replacement of the JLIB_RULES_SETTING_NOTES_ITEM language string override in file com_categories.ini by a string with the wrong name done with PR #35424 and remove the wrong string (which doesn't need a deprecation since never been in any stable or development release).

Testing Instructions

Edit a category and go to the "Permissions" tab. Expand the notes and check what's written there.

Actual result BEFORE applying this Pull Request

Standard language string is used in the permission notes.

Expected result AFTER applying this Pull Request

Special language string for categories is used in the permission notes.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 13 Nov 2022
avatar richard67 richard67 - change - 13 Nov 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2022
Category Administration Language & Strings
avatar Kostelano Kostelano - test_item - 13 Nov 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 13 Nov 2022

I have tested this item successfully on fed181b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39212.

avatar wilsonge
wilsonge - comment - 13 Nov 2022

We shouldn't have com_content stuff in the com_categories language file. Pretty sure we should be loading a com_content language file somewhere where this should come from - don't forget com_categories is shared between other components too - some 3PD's as well (sorry still waiting for my laptop so can't check myself exactly which file)

avatar richard67
richard67 - comment - 13 Nov 2022

We shouldn't have com_content stuff in the com_categories language file.

Ouch, I haven't noticed that. Will check and if possible correct.

avatar richard67 richard67 - change - 13 Nov 2022
Labels Added: Language Change PR-4.3-dev
avatar richard67
richard67 - comment - 13 Nov 2022

@wilsonge Thanks. Fixed it. Is 5.0 ok for the deprecation of the wrong string? Or should it be 6.0?

avatar richard67 richard67 - change - 13 Nov 2022
The description was changed
avatar richard67 richard67 - edited - 13 Nov 2022
avatar richard67
richard67 - comment - 13 Nov 2022

@Kostelano Sorry, I had to make a change (move the new string to the right file). Could you test again with these changes? Thanks in advance.

avatar Kostelano Kostelano - test_item - 13 Nov 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 13 Nov 2022

I have tested this item successfully on 1cced31


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39212.

avatar heelc29 heelc29 - test_item - 13 Nov 2022 - Tested unsuccessfully
avatar heelc29
heelc29 - comment - 13 Nov 2022

I have tested this item ? unsuccessfully on 1cced31

The categories component is also used in other components (eg. contacts).

image
image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39212.
avatar richard67
richard67 - comment - 13 Nov 2022

@heelc29 I am not sure if this justified a negative test result. This PR here fixes the issue where described. It does not introduce your observation as new issue so it is an old one on 4.3-dev which could be fixed with a separate PR.

avatar heelc29
heelc29 - comment - 13 Nov 2022

@richard67 It says Open category edit form and switch to tab Permissions. not especially for articles context. Wherever the category component is used, it was changed between 4.2.x and 4.3-dev.

avatar richard67
richard67 - comment - 13 Nov 2022

So either we have to add also language strings to other components' language files and expect the 3rd party developers whose components use categories to do the same, or we have to find the root cause why the com_categories string is not used in 4.3.

I'd prefer the latter of course and will see what I can find out or do, but if anyone else has an idea, please let us know.

avatar heelc29
heelc29 - comment - 13 Nov 2022

or we have to find the root cause why the com_categories string is not used in 4.3

is not used after apply PR #35424

In this PR an override of the JLIB_RULES_SETTING_NOTES_ITEM key was removed in administrator/language/en-GB/com_categories.ini

avatar richard67
richard67 - comment - 13 Nov 2022

or we have to find the root cause why the com_categories string is not used in 4.3

is not used after apply PR #35424

In this PR an override of the JLIB_RULES_SETTING_NOTES_ITEM key was removed in administrator/language/en-GB/com_categories.ini

I did understand that already. No need for bold letters. The question remains what is the right change, bring back that override or add component specific strings for other components which use categories.

@wilsonge What's your opinion?

avatar richard67
richard67 - comment - 13 Nov 2022

Since there are still other overrides of the JLIB tests in the com_categories file, see e.g. https://github.com/joomla/joomla-cms/blob/4.3-dev/administrator/language/en-GB/com_categories.ini#L77-L78 , which were touched by PR at first and later then reverted to the original state in that PR with this commit 22eb930 , I think we should do the same here and revert that one change to the previous state, too.

Will update this PR here in a minute.

avatar richard67 richard67 - change - 13 Nov 2022
The description was changed
avatar richard67 richard67 - edited - 13 Nov 2022
avatar richard67
richard67 - comment - 13 Nov 2022

@Kostelano Sorry, again I had to make a change. Now it works for all kinds of categories. Could you test again.

@heelc29 Please test again, too.

Thanks in advance to you both.

avatar Kostelano
Kostelano - comment - 13 Nov 2022

Why can't we just remove the JLIB_RULES_SETTING_NOTES_ITEM_COM_CATEGORIES line? It was added in 4.3-dev and has never been in the stable release yet.

avatar richard67
richard67 - comment - 13 Nov 2022

Why can't we just remove the JLIB_RULES_SETTING_NOTES_ITEM_COM_CATEGORIES line? It was added in 4.3-dev and has never been in the stable release yet.

Good question. Maybe I was just in the flow of regular releases and so didn't have that in mind.

avatar richard67 richard67 - change - 13 Nov 2022
The description was changed
avatar richard67 richard67 - edited - 13 Nov 2022
avatar richard67
richard67 - comment - 13 Nov 2022

@Kostelano Thanks, I've removed it.

avatar Kostelano Kostelano - test_item - 13 Nov 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 13 Nov 2022

I have tested this item successfully on 59c34e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39212.

avatar heelc29 heelc29 - test_item - 13 Nov 2022 - Tested successfully
avatar heelc29
heelc29 - comment - 13 Nov 2022

I have tested this item successfully on 59c34e8

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39212.

avatar richard67 richard67 - change - 13 Nov 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 13 Nov 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39212.

avatar obuisard obuisard - change - 14 Nov 2022
Labels Added: ?
avatar obuisard obuisard - close - 14 Nov 2022
avatar obuisard obuisard - merge - 14 Nov 2022
avatar obuisard obuisard - change - 14 Nov 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-11-14 20:13:17
Closed_By obuisard
avatar obuisard
obuisard - comment - 14 Nov 2022

Thank you Richard @richard67

Add a Comment

Login with GitHub to post a comment