No Code Attached Yet
avatar vicn1222
vicn1222
8 Nov 2022

Hello,

I have exactly the same issue described at https://www.drupal.org/project/drupal/issues/1116416

My joomla is installed in a sub-directory that has already doing a gzip compression, which causes double gzip encoding.

I change htaccess.txt as below:

Header set Content-Encoding gzip
Header set Vary Accept-Encoding

then the Joomla page works properly.

Thanks.

avatar vicn1222 vicn1222 - open - 8 Nov 2022
avatar vicn1222 vicn1222 - change - 8 Nov 2022
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Nov 2022
avatar richard67
richard67 - comment - 9 Nov 2022

I change htaccess.txt as below:

I doubt that a change on htaccess.txt had any impact on your webserver ? .

I assume you've changed .htaccess.

Header set Content-Encoding gzip
Header set Vary Accept-Encoding

You mean here? https://github.com/joomla/joomla-cms/blob/4.2-dev/htaccess.txt#L164-L171

avatar richard67
richard67 - comment - 9 Nov 2022

P.S.: I was reading the complete discussion in the drupal issue thread and at the end they concluded to change only the Header set Content-Encoding gzip.

The Header append Vary Accept-Encoding they left as it was because the vary header can have multiple values, so that was not a problem.

See https://www.drupal.org/project/drupal/issues/1116416#comment-4719426 for the corresponding comment and https://www.drupal.org/files/issues/use_set_rather_than_append-1116416-6.patch for their final patch.

avatar vicn1222
vicn1222 - comment - 11 Nov 2022

Of course I change .htaccess after copying from htaccess.txt :-)

Joomla doesn't come with .htaccess, but htaccess.txt, so I said htaccess.txt (*_^)

Maybe "Header append Vary Accept-Encoding" doesn't need to be changed, but "Header append Content-Encoding gzip" shoud.

Cheers


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39176.

avatar richard67
richard67 - comment - 11 Nov 2022

Maybe "Header append Vary Accept-Encoding" doesn't need to be changed, but "Header append Content-Encoding gzip" shoud.

@vicn1222 Agreed.

Do you want to make a pull request so you get the honour and fame for having fixed that? If so, you should provide some testing instructions. If you don't want or can't make a PR, let me know here, than I can make one. Would be great if you could test it then.

avatar vicn1222
vicn1222 - comment - 12 Nov 2022

@richard67 Please make the request.

I have tested both standalone and inside a sub-direction. Both work well without issue. Without that change, the joomla inside a sub-directory causes the issue, and my google search lead me to the solution by drupal user.

Thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39176.

avatar vicn1222
vicn1222 - comment - 12 Nov 2022

@richard67 Please make the request.

I have tested both standalone and inside a sub-direction. Both work well without issue. Without that change, the joomla inside a sub-directory causes the issue, and my google search lead me to the solution by drupal user.

Thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39176.

avatar vicn1222
vicn1222 - comment - 12 Nov 2022

@richard67

Hi Richard, could you please also make request for this bug? https://issues.joomla.org/tracker/joomla-cms/38899

The new update didn't take my fix. Please feel free to make changes as necessary.

Many thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39176.

avatar richard67 richard67 - change - 12 Nov 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-11-12 13:47:16
Closed_By richard67
avatar richard67 richard67 - close - 12 Nov 2022
avatar richard67
richard67 - comment - 12 Nov 2022

Closing as having a pull request.

@vicn1222 Please test #39205 and when having tested, go to the PR in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/39205 , use the blue "Test this" button at the top left corner, select your test result and then submit. Thanks in advance.

For the other issue which you have mentioned I am not sure if I will make a pull request. I have to check later.

Add a Comment

Login with GitHub to post a comment