[#39173] - [4.3] Prevent modal from closing when showing an error
- Fixed in Code Base
- 28 Aug 2023
- Medium
- Build: 4.2-dev
- # 39173
- Diff
- heelc29:patch-39150
User tests: Successful: Unsuccessful:
Pull Request for Issue #39150 .
Summary of Changes
The modal is only closed if the iframe does not contain an element joomla-alert[type="danger"].
Testing Instructions
see #39150
The error also occurs with Single Contact (if name contains only spaces):
Actual result BEFORE applying this Pull Request
Modal is closed
Expected result AFTER applying this Pull Request
Modal still open and show error message (like when only Save is clicked)
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
This pull request has been automatically rebased to 4.3-dev.
| Labels |
Added:
NPM Resource Changed
bug
?
?
|
||
| Title |
|
||||||
| Labels |
Added:
PR-4.3-dev
Removed: ? |
||
I have tested this item ✅ successfully on bc5f9c3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39173.
I have tested this item ✅ successfully on bc5f9c3
I tested the case from the issue and the PR does not let the modal close.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39173.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39173.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-28 19:25:25 |
| Closed_By | ⇒ | obuisard |
@heelc29 can you please contact me vicepresident.at.opensourcematters.org